Skip to content

STYLE: Mark FFTW 1D FFT class destructors with override#2816

Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
tbirdso:OverrideFFTW1DFFTClassDestructors
Oct 15, 2021
Merged

STYLE: Mark FFTW 1D FFT class destructors with override#2816
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
tbirdso:OverrideFFTW1DFFTClassDestructors

Conversation

@tbirdso
Copy link
Copy Markdown
Contributor

@tbirdso tbirdso commented Oct 14, 2021

Extend changes from #2815 (review) to FFTW classes.

Note that FFTW class implementation details are conditioned on compiler directives for using the FFTW backend. Constructors and destructors are defined in respective header template files and are not default.

PR Checklist

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions Bot added area:Filtering Issues affecting the Filtering module type:Style Style changes: no logic impact (indentation, comments, naming) labels Oct 14, 2021
@seanm
Copy link
Copy Markdown
Contributor

seanm commented Oct 14, 2021

lgtm

Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @tbirdso !

@thewtex thewtex merged commit f77befe into InsightSoftwareConsortium:master Oct 15, 2021
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
…deFFTW1DFFTClassDestructors

STYLE: Mark FFTW 1D FFT class destructors with `override`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Filtering Issues affecting the Filtering module type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants