Skip to content

STYLE: Use exit return codes consistently in tests#2940

Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:UseTestExitCodesConsistently
Dec 13, 2021
Merged

STYLE: Use exit return codes consistently in tests#2940
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:UseTestExitCodesConsistently

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta commented Dec 11, 2021

Use exit return codes consistently in tests.

Use the ITK_TRY_EXPECT_NO_EXCEPTION macro where appropriate to avoid
boilerplate code.

PR Checklist

@github-actions github-actions Bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Dec 11, 2021
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Dec 11, 2021

Will probably need to be rebased on master after PR #2939 gets merged.

Cross-referencing #2939 (comment)

@jhlegarreta jhlegarreta force-pushed the UseTestExitCodesConsistently branch from 0846c60 to 58ef5e6 Compare December 11, 2021 21:28
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Dec 12, 2021 •
edited
Loading

The failing itkPyBufferMemoryLeakTest seems unrelated to this patch set.

@jhlegarreta jhlegarreta mentioned this pull request Dec 12, 2021
Merged
2 tasks
@PranjalSahu
Copy link
Copy Markdown
Contributor

PranjalSahu commented Dec 12, 2021

Multiple PRs have the same failure.

@jhlegarreta
STYLE: Use exit return codes consistently in tests
3f429da 
Use exit return codes consistently in tests.

Use the `ITK_TRY_EXPECT_NO_EXCEPTION` macro where appropriate to avoid
boilerplate code.
@jhlegarreta jhlegarreta force-pushed the UseTestExitCodesConsistently branch from 58ef5e6 to 3f429da Compare December 12, 2021 23:04
@hjmjohnson hjmjohnson merged commit a98f7a8 into InsightSoftwareConsortium:master Dec 13, 2021
@jhlegarreta jhlegarreta deleted the UseTestExitCodesConsistently branch December 13, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhlegarreta @PranjalSahu @hjmjohnson