Skip to content

ENH: JPEG IO: test another damaged file#2978

Closed
issakomi wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
issakomi:jpgtest
Closed

ENH: JPEG IO: test another damaged file#2978
issakomi wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
issakomi:jpgtest

Conversation

@issakomi
Copy link
Copy Markdown
Member

@issakomi issakomi commented Dec 18, 2021

JPEG has different scenarios for damaged files. This image triggers jump in JPEG library and ITK exception.
Increased coverage.

S. #2933 (comment)

JPEG has different scenarios for damaged files.
Increase coverage.
@github-actions github-actions Bot added area:IO Issues affecting the IO module type:Data Changes to testing data type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Dec 18, 2021
@issakomi issakomi changed the title ENH: JPEG IO test another damaged file ENH: JPEG IO: test another damaged file Dec 18, 2021
@dzenanz dzenanz requested a review from jhlegarreta December 20, 2021 15:25
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding another test @issakomi ! The test file itkJPEGImageIODegenerateCasesTest.cxx was conforming to the style in the ITK SW Guide guidelines, so please amend the commit to discard the changes to it.

@issakomi issakomi closed this Dec 20, 2021
@issakomi issakomi deleted the jpgtest branch December 20, 2021 15:35
@issakomi issakomi restored the jpgtest branch December 21, 2021 13:07
@issakomi issakomi deleted the jpgtest branch December 24, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:IO Issues affecting the IO module type:Data Changes to testing data type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants