ENH: Add default FFT object factories to TestKernel initialization#3002
Merged
thewtex merged 3 commits intoInsightSoftwareConsortium:masterfrom Jan 7, 2022
Merged
Conversation
github-actions
Bot
added
area:Core
dzenanz
reviewed
Dec 27, 2021
Member
|
It looks like https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Filtering/FFT/include/itkFFTImageFilterFactory.h should |
tbirdso
force-pushed
the
test-kernel-register-fft-factories
branch
from
8a7ed02 to
1595150
Compare
tbirdso
commented
Dec 27, 2021
dzenanz
approved these changes
Dec 28, 2021
tbirdso
force-pushed
the
test-kernel-register-fft-factories
branch
from
46e337c to
1595150
Compare
tbirdso
force-pushed
the
test-kernel-register-fft-factories
branch
from
1595150 to
b079645
Compare
dzenanz
approved these changes
Dec 28, 2021
3 tasks
thewtex
requested changes
Dec 29, 2021
Member
thewtex
left a comment
thewtex
left a comment
There was a problem hiding this comment.
@tbirdso looking good!
To improve the consistency of the factories registered by default by the test driver, just the VNL factories can be registered. If other factories are required by a test, e.g. FFTW, CUDA, VkFFT, they should be explicitly registered or used directly be the test.
Member
@tbirdso @jhlegarreta this will help with #3008 , for example |
tbirdso
force-pushed
the
test-kernel-register-fft-factories
branch
from
eb922f7 to
272504f
Compare
Contributor
Author
|
Rebased on |
tbirdso
force-pushed
the
test-kernel-register-fft-factories
branch
from
073aba4 to
e31ef5e
Compare
tbirdso
force-pushed
the
test-kernel-register-fft-factories
branch
from
e31ef5e to
0e64245
Compare
Contributor
Author
|
@thewtex Could this please be reviewed again? |
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…ernel-register-fft-factories ENH: Add default FFT object factories to TestKernel initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses remote module test failures in #2950 by adding FFT factories to the list of default factories to be registered with ITKTestKernel.
itkTestDriverIncludeRequiredIOFactories.hand similar strings are renamed toitkTestDriverIncludeRequiredFactories.hto reflect that FFT factories and any other future backends managed with the object factory should be default registered here. Manual FFT factory registrations previously required for testing are removed.ITKMontage tests pass when these changes are applied.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.