COMP: Fix testing macro call and array initialization errors#3017
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Jan 1, 2022
Merged
Conversation
Fix call to basic object method exercise macro and array initialization
compilation errors.
Fixes:
```
[CTest: warning matched]
/Users/builder/external/ITK-AppleClang-dbg-Universal/Modules/ThirdPartysrc/vxl/vcl/vcl_compiler.h:2:9:
warning: macro name is a reserved identifier [-Wreserved-id-macro]
^
/Users/builder/externalModules/Core/Transform/test/itkRigid3DPerspectiveTransformTest.cxx:62:46:
error: use of undeclared identifier 'Rigid3DPerspectiveTransform'
EXERCISE_BASIC_OBJECT_METHODS(transform, Rigid3DPerspectiveTransform, Transform);
^
/Users/builder/externalModules/Core/Transform/test/itkRigid3DPerspectiveTransformTest.cxx:62:75:
error: use of undeclared identifier 'Transform'
EXERCISE_BASIC_OBJECT_METHODS(transform, Rigid3DPerspectiveTransform, Transform);
^
[CTest: warning matched] 1 warning and 2 errors generated.
```
and
```
[CTest: warning matched]
/Users/builder/externalModules/Core/Transform/test/itkRigid3DPerspectiveTransformTest.cxx:42:55:
warning: suggest braces around initialization of subobject [-Wmissing-braces]
typename TransformType::InputVectorType vector{ { 1.0, 4.0, 9.0 } };
^~~~~~~~~~~~~
{ }
[CTest: warning matched]
/Users/builder/externalModules/Core/Transform/test/itkRigid3DPerspectiveTransformTest.cxx:53:59:
warning: suggest braces around initialization of subobject [-Wmissing-braces]
typename TransformType::InputPointType point{ { 1.0, 1.0, 1.0 } };
^~~~~~~~~~~~~
{ }
[CTest: warning suppressed] 2 warnings generated.
```
and
```
[CTest: warning matched]
/Users/builder/externalModules/Filtering/FastMarching/test/itkFastMarchingTest.cxx:155:73:
warning: suggest braces around initialization of subobject [-Wmissing-braces]
typename FloatFMType::LevelSetImageType::IndexType outputRegionIndex{ outputRegionIndexValue };
^~~~~~~~~~~~~~~~~~~~~~
{ }
[CTest: warning suppressed] 1 warning generated.
```
reported for example in:
https://open.cdash.org/viewBuildError.php?buildid=7652795
and
https://open.cdash.org/viewBuildError.php?type=1&buildid=7652659
Member
Author
|
All introduced in PR #3003. My bad. |
dzenanz
approved these changes
Dec 31, 2021
Member
dzenanz
left a comment
There was a problem hiding this comment.
Thanks for the follow-up. No need to apologize!
hjmjohnson
approved these changes
Jan 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix call to basic object method exercise macro and array initialization
compilation errors.
Fixes:
and
and
reported for example in:
https://open.cdash.org/viewBuildError.php?buildid=7652795
and
https://open.cdash.org/viewBuildError.php?type=1&buildid=7652659
PR Checklist