Better progress reporting#3052
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Jan 10, 2022
Merged
Conversation
Before 840bae7 for some filters progress would go from 0% to 100% twice, overflowing from 100% to 0% about halfway. After 840bae7, the progress would fill up to 100% during first half of the work, and stayed there the entire second half of the work. With this commit, progress is reported as expected: it fills up to 50% during first half of the work, and fills up to 100% during second half of the work. The progress should be filling up smoothly, in small increments. This is because we now disable UpdateProgres in MultiThreader in class constructors of classes which report filter progress. Closes InsightSoftwareConsortium#2875.
Member
Author
|
Brad can you test this with SimpleITK? |
Member
@dzenanz I quickly rebuild and ran SimpleITK's test suit and it appears to be OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #3014. Closes #2875.