BUG: fixed simultaneous read/write access of same ivar by different t…#3115
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Jan 18, 2022
Merged
Conversation
…hreads Made the ivar atomic, so at least the simultaneous access is well-defined. Found by TSan. A great many tests were failing because of this.
github-actions
Bot
added
area:Core
dzenanz
approved these changes
Jan 17, 2022
Contributor
Author
|
BTW I think this is a recent regression, but did not check history/blame. TSan used to have only hundreds of failures, but now has thousands. I think most are due to this. |
Member
|
Can you take a look at #3116 and try to figure out the hang in a few filters? It might not be even all of these now, but only two of them (Laplacian and one more). |
hjmjohnson
approved these changes
Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hreads
Made the ivar atomic, so at least the simultaneous access is well-defined.
Found by TSan. A great many tests were failing because of this.