STYLE: Prefer default constructors#3162
Merged
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom Feb 5, 2022
Merged
STYLE: Prefer default constructors#3162dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom
Conversation
github-actions
Bot
added
area:Filtering
N-Dekker
reviewed
Feb 4, 2022
Contributor
There was a problem hiding this comment.
@hjmjohnson Please check: the commit text seems unrelated to the commit itself! 142a9ed ("STYLE: Remove outdated debugging statements") does not remove any itkDebugMacro, and it does not add any = default either!
dzenanz
reviewed
Feb 4, 2022
Converts a default constructor’s member initializers into the new default member initializers in C++11. Other member initializers that match the default member initializer are removed. This can reduce repeated code or allow use of ‘= default’.
This check replaces default bodies of special member functions with = default;. The explicitly defaulted function declarations enable more opportunities in optimization, because the compiler might treat explicitly defaulted functions as trivial. Additionally, the C++11 use of = default more clearly expreses the intent for the special member functions.
hjmjohnson
force-pushed
the
make-default-constructors
branch
from
15dc097 to
5031424
Compare
dzenanz
approved these changes
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist