STYLE: Use default member initialization

.gitattributes

@@ -42,3 +42,4 @@ zap.pl           crlf=input
 *                     hooks-max-size=100000
 Modules/ThirdParty/** hooks-max-size=300000
 Modules/ThirdParty/VNL/src/vxl/v3p/netlib/triangle.c hooks-max-size=670000
+Modules/Filtering/Denoising/include/itkPatchBasedDenoisingImageFilter.hxx hooks-max-size=120000

Examples/DataRepresentation/Image/ImageAdaptor3.cxx

@@ -69,7 +69,7 @@ class VectorPixelAccessor
   using InternalType = itk::CovariantVector<float,2>;
   using ExternalType = float;
 
-  VectorPixelAccessor() : m_Index(0) {}
+  VectorPixelAccessor()  {}
 
   VectorPixelAccessor & operator=( const VectorPixelAccessor & vpa ) = default;
   ExternalType Get( const InternalType & input ) const
@@ -82,7 +82,7 @@ class VectorPixelAccessor
     }
 
 private:
-  unsigned int m_Index;
+  unsigned int m_Index{0};
 };
 // Software Guide : EndCodeSnippet
 }

Examples/DataRepresentation/Image/ImageAdaptor4.cxx

@@ -65,7 +65,7 @@ class ThresholdingPixelAccessor
   using InternalType = unsigned char;
   using ExternalType = unsigned char;
 
-  ThresholdingPixelAccessor() : m_Threshold(0) {};
+  ThresholdingPixelAccessor()  {};
 
   ExternalType Get( const InternalType & input ) const
     {
@@ -80,7 +80,7 @@ class ThresholdingPixelAccessor
     operator=( const ThresholdingPixelAccessor & vpa ) = default;
 
 private:
-  InternalType m_Threshold;
+  InternalType m_Threshold{0};
 };
 }
 

Examples/RegistrationITKv4/MultiResImageRegistration1.cxx

@@ -281,7 +281,7 @@ class CommandIterationUpdate : public itk::Command
   itkNewMacro( Self );
 
 protected:
-  CommandIterationUpdate(): m_CumulativeIterationIndex(0) {};
+  CommandIterationUpdate() {};
 
 public:
   using OptimizerType = itk::RegularStepGradientDescentOptimizerv4<double>;
@@ -305,7 +305,7 @@ class CommandIterationUpdate : public itk::Command
   std::cout << m_CumulativeIterationIndex++ << std::endl;
   }
 private:
-  unsigned int m_CumulativeIterationIndex;
+  unsigned int m_CumulativeIterationIndex{0};
 };
 
 

Examples/RegistrationITKv4/MultiResImageRegistration2.cxx

@@ -79,7 +79,7 @@ class CommandIterationUpdate : public itk::Command
   itkNewMacro( Self );
 
 protected:
-  CommandIterationUpdate(): m_CumulativeIterationIndex(0) {};
+  CommandIterationUpdate() {};
 
 public:
   using OptimizerType = itk::RegularStepGradientDescentOptimizer;
@@ -105,7 +105,7 @@ class CommandIterationUpdate : public itk::Command
     }
 
 private:
-  unsigned int m_CumulativeIterationIndex;
+  unsigned int m_CumulativeIterationIndex{0};
 };
 
 //  The following section of code implements a Command observer

Examples/RegistrationITKv4/MultiStageImageRegistration1.cxx

@@ -135,7 +135,7 @@ class CommandIterationUpdate : public itk::Command
   itkNewMacro( Self );
 
 protected:
-  CommandIterationUpdate(): m_CumulativeIterationIndex(0) {};
+  CommandIterationUpdate() {};
 
 public:
   using OptimizerType = itk::GradientDescentOptimizerv4Template<double>;
@@ -160,7 +160,7 @@ class CommandIterationUpdate : public itk::Command
     }
 
 private:
-  unsigned int m_CumulativeIterationIndex;
+  unsigned int m_CumulativeIterationIndex{0};
 };
 
 int main( int argc, char *argv[] )

Examples/RegistrationITKv4/MultiStageImageRegistration2.cxx

@@ -133,7 +133,7 @@ class CommandIterationUpdate : public itk::Command
   itkNewMacro( Self );
 
 protected:
-  CommandIterationUpdate(): m_CumulativeIterationIndex(0) {};
+  CommandIterationUpdate() {};
 
 public:
   using OptimizerType = itk::GradientDescentOptimizerv4Template<double>;
@@ -162,7 +162,7 @@ class CommandIterationUpdate : public itk::Command
     }
 
 private:
-  unsigned int m_CumulativeIterationIndex;
+  unsigned int m_CumulativeIterationIndex{0};
 };
 
 int main( int argc, char *argv[] )

Modules/Core/Common/include/itkAnnulusOperator.h

@@ -84,10 +84,7 @@ class ITK_TEMPLATE_EXPORT AnnulusOperator:
 
   AnnulusOperator():
     NeighborhoodOperator< TPixel, TDimension, TAllocator >(),
-    m_InnerRadius(1.0),
-    m_Thickness( 1.0 ),
-    m_Normalize(false),
-    m_BrightCenter(false),
+
     m_InteriorValue(NumericTraits< PixelType >::ZeroValue()),
     m_AnnulusValue(NumericTraits< PixelType >::OneValue()),
     m_ExteriorValue(NumericTraits< PixelType >::ZeroValue()),
@@ -220,10 +217,10 @@ class ITK_TEMPLATE_EXPORT AnnulusOperator:
 
 private:
 
-  double      m_InnerRadius;
-  double      m_Thickness;
-  bool        m_Normalize;
-  bool        m_BrightCenter;
+  double      m_InnerRadius{1.0};
+  double      m_Thickness{ 1.0 };
+  bool        m_Normalize{false};
+  bool        m_BrightCenter{false};
   PixelType   m_InteriorValue;
   PixelType   m_AnnulusValue;
   PixelType   m_ExteriorValue;

Modules/Core/Common/include/itkAutoPointer.h

@@ -51,7 +51,7 @@ class AutoPointer
   using Self = AutoPointer;
 
   /** Constructor.  */
-  AutoPointer ():m_Pointer(nullptr), m_IsOwner(false)
+  AutoPointer ():m_Pointer(nullptr)
   {}
 
   /** Copy constructor.  */
@@ -201,7 +201,7 @@ class AutoPointer
 
   /** The pointer to the object referred to by this smart pointer. */
   ObjectType *m_Pointer;
-  bool        m_IsOwner;
+  bool        m_IsOwner{false};
 };
 
 template< typename T >

Modules/Core/Common/include/itkBarrier.h

@@ -76,9 +76,9 @@ class ITKCommon_EXPORT Barrier
   Barrier();
   ~Barrier() override;
 
-  unsigned int            m_NumberArrived;
-  unsigned int            m_NumberExpected;
-  unsigned int            m_Generation; // Allows successive waits
+  unsigned int            m_NumberArrived{0};
+  unsigned int            m_NumberExpected{0};
+  unsigned int            m_Generation{0}; // Allows successive waits
   std::condition_variable m_ConditionVariable;
   std::mutex              m_Mutex;
 };

Modules/Core/Common/include/itkColorTable.h

@@ -118,7 +118,7 @@ class ITK_TEMPLATE_EXPORT ColorTable:public Object
 
   void DeleteColors();
 
-  unsigned int m_NumberOfColors;
+  unsigned int m_NumberOfColors{ 0 };
 
   ColorNameVectorType         m_ColorName;
   ColorVectorType             m_Color;

Modules/Core/Common/include/itkColorTable.hxx

@@ -29,8 +29,7 @@ namespace itk
 {
 template< typename TPixel >
 ColorTable< TPixel >
-::ColorTable() :
-  m_NumberOfColors( 0 )
+::ColorTable()
 {
 }
 

Modules/Core/Common/include/itkCommand.h

@@ -395,10 +395,10 @@ class ITKCommon_EXPORT CStyleCommand:public Command
   CStyleCommand();
   ~CStyleCommand() override;
 
-  void *                    m_ClientData;
-  FunctionPointer           m_Callback;
-  ConstFunctionPointer      m_ConstCallback;
-  DeleteDataFunctionPointer m_ClientDataDeleteCallback;
+  void *                    m_ClientData{ nullptr };
+  FunctionPointer           m_Callback{ nullptr };
+  ConstFunctionPointer      m_ConstCallback{ nullptr };
+  DeleteDataFunctionPointer m_ClientDataDeleteCallback{ nullptr };
 };
 } // end namespace itk
 

Modules/Core/Common/include/itkConditionalConstIterator.h

@@ -111,7 +111,7 @@ class ITK_TEMPLATE_EXPORT ConditionalConstIterator
   RegionType m_Region;
 
   /** Is the iterator at the end of its walk? */
-  bool m_IsAtEnd;
+  bool m_IsAtEnd{false};
 };
 } // end namespace itk
 

Modules/Core/Common/include/itkConditionalConstIterator.hxx

@@ -24,7 +24,7 @@ namespace itk
 {
 template< typename TImageType >
 ConditionalConstIterator< TImageType >
-::ConditionalConstIterator() : m_IsAtEnd(false)
+::ConditionalConstIterator()
 {}
 
 template< typename TImageType >

Modules/Core/Common/include/itkConicShellInteriorExteriorSpatialFunction.h

@@ -124,10 +124,10 @@ class ITK_TEMPLATE_EXPORT ConicShellInteriorExteriorSpatialFunction:
 private:
   InputType     m_Origin;
   GradientType  m_OriginGradient;
-  double        m_DistanceMin;
-  double        m_DistanceMax;
-  double        m_Epsilon;
-  bool          m_Polarity;
+  double        m_DistanceMin{ 0.0 };
+  double        m_DistanceMax{ 0.0 };
+  double        m_Epsilon{ 0.0 };
+  bool          m_Polarity{ false };
 };
 } // end namespace itk
 

Modules/Core/Common/include/itkConicShellInteriorExteriorSpatialFunction.hxx

@@ -24,11 +24,8 @@ namespace itk
 {
 template< unsigned int VDimension, typename TInput >
 ConicShellInteriorExteriorSpatialFunction< VDimension, TInput >
-::ConicShellInteriorExteriorSpatialFunction() :
-  m_DistanceMin( 0.0 ),
-  m_DistanceMax( 0.0 ),
-  m_Epsilon( 0.0 ),
-  m_Polarity( false )
+::ConicShellInteriorExteriorSpatialFunction()
+
 {
   m_Origin.Fill(0.0);
   m_OriginGradient.Fill(0.0);

Modules/Core/Common/include/itkConstNeighborhoodIterator.h

@@ -524,12 +524,12 @@ class ITK_TEMPLATE_EXPORT ConstNeighborhoodIterator:
   mutable bool m_InBounds[Dimension];
 
   /** Denotes if iterator is entirely within bounds */
-  mutable bool m_IsInBounds;
+  mutable bool m_IsInBounds{false};
 
   /** Is the m_InBounds and m_IsInBounds variables up to date? Set to
    * false whenever the iterator is repositioned.  Set to true within
    * InBounds(). */
-  mutable bool m_IsInBoundsValid;
+  mutable bool m_IsInBoundsValid{false};
 
   /** Lower threshold of in-bounds loop counter values. */
   IndexType m_InnerBoundsLow;
@@ -541,7 +541,7 @@ class ITK_TEMPLATE_EXPORT ConstNeighborhoodIterator:
   TBoundaryCondition m_InternalBoundaryCondition;
 
   /** Does the specified region need to worry about boundary conditions? */
-  bool m_NeedToUseBoundaryCondition;
+  bool m_NeedToUseBoundaryCondition{false};
 
   /** Functor type used to access neighborhoods of pixel pointers */
   NeighborhoodAccessorFunctorType m_NeighborhoodAccessorFunctor;

Modules/Core/Common/include/itkConstNeighborhoodIterator.hxx

@@ -212,10 +212,8 @@ ConstNeighborhoodIterator< TImage, TBoundaryCondition >
 
 template< typename TImage, typename TBoundaryCondition >
 ConstNeighborhoodIterator< TImage, TBoundaryCondition >
-::ConstNeighborhoodIterator() :
-  m_IsInBounds(false),
-  m_IsInBoundsValid(false),
-  m_NeedToUseBoundaryCondition(false)
+::ConstNeighborhoodIterator()
+
 {
   IndexType zeroIndex; zeroIndex.Fill(0);
   SizeType zeroSize; zeroSize.Fill(0);

Modules/Core/Common/include/itkDataObject.h

@@ -84,7 +84,7 @@ class ITKCommon_EXPORT DataObjectError:public ExceptionObject
   virtual void PrintSelf(std::ostream & os, Indent indent) const;
 
 private:
-  DataObject *m_DataObject;
+  DataObject *m_DataObject{nullptr};
 };
 
 /** \class InvalidRequestRegionError

Modules/Core/Common/include/itkDefaultVectorPixelAccessor.h

@@ -92,7 +92,7 @@ class ITK_TEMPLATE_EXPORT DefaultVectorPixelAccessor
   /** Get Vector lengths */
   VectorLengthType GetVectorLength() const { return m_VectorLength; }
 
-  DefaultVectorPixelAccessor() : m_VectorLength(0), m_OffsetMultiplier(0) {}
+  DefaultVectorPixelAccessor()  {}
 
   /** Constructor to initialize VectorLength at construction time */
   DefaultVectorPixelAccessor(VectorLengthType l)
@@ -104,8 +104,8 @@ class ITK_TEMPLATE_EXPORT DefaultVectorPixelAccessor
   ~DefaultVectorPixelAccessor() = default;
 
 private:
-  VectorLengthType m_VectorLength;
-  VectorLengthType m_OffsetMultiplier;
+  VectorLengthType m_VectorLength{0};
+  VectorLengthType m_OffsetMultiplier{0};
 };
 } // end namespace itk
 

Modules/Core/Common/include/itkDerivativeOperator.h

@@ -77,7 +77,7 @@ class ITK_TEMPLATE_EXPORT DerivativeOperator:
   using PixelRealType = typename Superclass::PixelRealType;
 
   /** Constructor. */
-  DerivativeOperator():m_Order(1) {}
+  DerivativeOperator() {}
 
   /** Copy constructor. */
   DerivativeOperator(const Self & other):
@@ -126,7 +126,7 @@ class ITK_TEMPLATE_EXPORT DerivativeOperator:
 
 private:
   /** Order of the derivative. */
-  unsigned int m_Order;
+  unsigned int m_Order{1};
 };
 } // namespace itk
 

Modules/Core/Common/include/itkDomainThreader.h

@@ -168,7 +168,7 @@ class ITK_TEMPLATE_EXPORT DomainThreader: public Object
    * the number allocated by the threader if the object does not split
    * well into that number.
    * This value is determined at the beginning of \c Execute(). */
-  ThreadIdType                             m_NumberOfWorkUnitsUsed;
+  ThreadIdType                             m_NumberOfWorkUnitsUsed{0};
   ThreadIdType                             m_NumberOfWorkUnits;
   typename DomainPartitionerType::Pointer  m_DomainPartitioner;
   DomainType                               m_CompleteDomain;

Modules/Core/Common/include/itkDomainThreader.hxx

@@ -26,8 +26,8 @@ namespace itk
 template< typename TDomainPartitioner, typename TAssociate >
 DomainThreader< TDomainPartitioner, TAssociate >
 ::DomainThreader()
-  : m_Associate(nullptr),
-    m_NumberOfWorkUnitsUsed(0)
+  : m_Associate(nullptr)
+
 {
   this->m_DomainPartitioner = DomainPartitionerType::New();
   this->m_MultiThreader = MultiThreaderBase::New();

Modules/Core/Common/include/itkFrustumSpatialFunction.h

@@ -105,11 +105,11 @@ class ITK_TEMPLATE_EXPORT FrustumSpatialFunction:
 
 private:
   InputType                 m_Apex;
-  double                    m_AngleZ;
-  double                    m_ApertureAngleX;
-  double                    m_ApertureAngleY;
-  double                    m_TopPlane;
-  double                    m_BottomPlane;
+  double                    m_AngleZ{ 0.0f };
+  double                    m_ApertureAngleX{ 0.0f };
+  double                    m_ApertureAngleY{ 0.0f };
+  double                    m_TopPlane{ 0.0f };
+  double                    m_BottomPlane{ 0.0f };
   FrustumRotationPlaneType  m_RotationPlane;
 };
 } // end namespace itk

Modules/Core/Common/include/itkFrustumSpatialFunction.hxx

@@ -24,11 +24,7 @@ namespace itk
 {
 template< unsigned int VDimension, typename TInput >
 FrustumSpatialFunction< VDimension, TInput >::FrustumSpatialFunction() :
-  m_AngleZ( 0.0f ),
-  m_ApertureAngleX( 0.0f ),
-  m_ApertureAngleY( 0.0f ),
-  m_TopPlane( 0.0f ),
-  m_BottomPlane( 0.0f ),
+
   m_RotationPlane( RotateInXZPlane )
 {
   m_Apex.Fill( 0.0f );