STYLE: Encapsulate NiftiImage qto_xyz mat44 data as Matrix<float,4,4>#3327
Conversation
Using `itk::Matrix<float, 4, 4>` (instead of `std::vector<float>`) to store the "qto_xyz" data from m_NiftiImage, as this `Matrix` template instantiation more closely resembles the original niftilib `mat44` data structure.
6eb549b to
e960125
Compare
|
OK, give me a chance to try this in my app, want to make sure it actually works for me... |
Thanks @seanm I'm not in a hurry 😃 If you want be sure than it does not get merged accidentally, you may do BTW, instead of using |
|
OK, I've tested, this is good for me. (Calling it "STYLE" seems a little light though, it is a behaviour and public API change, even though the old way didn't ship in a release.) |
Using
itk::Matrix<float, 4, 4>(instead ofstd::vector<float>) to store the "qto_xyz" data from m_NiftiImage, as thisMatrixtemplate instantiation more closely resembles the original niftilibmat44data structure.Follow-up to pull request #3242 commit 9eb4c12 "ENH: bug #3241: Add qfac and qto_xyz to itkNiftiImageIO metadata" by Sean McBride (@seanm), which was merged on March 17, 2022.