ENH: Increase coverage for itk::ImageRegistrationMethodv4#3633
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Sep 19, 2022
Conversation
github-actions
Bot
added
area:Registration
jhlegarreta
force-pushed
the
IncreaseImageRegistrationMethodv4Coverage
branch
2 times, most recently
from
6c61b3c to
40d78f4
Compare
Increase coverage for `itk::ImageRegistrationMethodv4`: - Test the Set/Get methods using the `ITK_TEST_SET_GET_VALUE` macro. - Test the boolean ivars using the `ITK_TEST_SET_GET_BOOLEAN` macro. - Test other getter methods by serializing the data to the standard output.
jhlegarreta
force-pushed
the
IncreaseImageRegistrationMethodv4Coverage
branch
from
40d78f4 to
0dc0b98
Compare
hjmjohnson
approved these changes
Sep 19, 2022
Member
Author
|
Coverage has been consistently over 90% since this PR. Slightly over a hundred lines have lost their coverage since then due to some refactoring works, but coverage has not dropped below the mentioned percentage. A year and a half ago we also achieved over 90% coverage, but shortly after we fell back to 88%. Raising the coverage back to 90% has required no small effort since then. Hope we can increase it to be above 90% consistently. Cross-referencing #2327 (comment). Thanks to all that have made this possible, and tagging @luisibanez as for a prolonged period, he was at the core of those propelling this effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase coverage for
itk::ImageRegistrationMethodv4:ITK_TEST_SET_GET_VALUEmacro.ITK_TEST_SET_GET_BOOLEANmacro.PR Checklist