Skip to content

STYLE: Declare BlockMatchingImageFilter data members as unique_ptr<T[]>#3670

Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Declare-BlockMatchingImageFilter-data-unique_ptr
Oct 12, 2022
Merged

STYLE: Declare BlockMatchingImageFilter data members as unique_ptr<T[]>#3670
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Declare-BlockMatchingImageFilter-data-unique_ptr

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added area:Registration Issues affecting the Registration module type:Style Style changes: no logic impact (indentation, comments, naming) labels Sep 29, 2022
@N-Dekker
Copy link
Copy Markdown
Contributor Author

"First interaction / build (pull_request_target)" has failed! Any suggestion?

It says:

internal/modules/cjs/loader.js:1216
      throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);
      ^

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /node_modules/@octokit/graphql/index.js
require() of ES modules is not supported.
require() of /node_modules/@octokit/graphql/index.js from /node_modules/@actions/github/lib/github.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /node_modules/@octokit/graphql/package.json.

@dzenanz
Copy link
Copy Markdown
Member

dzenanz commented Sep 29, 2022

The action probably broke again. Hopefully, someone (action author) will fix it soon, without us having to put effort into it. We can ignore this "failure" for the purposes of merging PRs.

@N-Dekker
Copy link
Copy Markdown
Contributor Author

The action probably broke again. Hopefully, someone (action author) will fix it soon, without us having to put effort into it. We can ignore this "failure" for the purposes of merging PRs.

Thanks @dzenanz I see now, the same failure occurred with PR #3671, which I just submitted as well.

@N-Dekker N-Dekker marked this pull request as ready for review September 29, 2022 21:59
@hjmjohnson hjmjohnson merged commit 64a5cd8 into InsightSoftwareConsortium:master Oct 12, 2022
thewtex added a commit to thewtex/ITK that referenced this pull request Nov 19, 2023
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Registration Issues affecting the Registration module type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants