COMP: Fix MSVC warning C26495: m_PositionIndex uninitialized#3849
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Jan 4, 2023
Conversation
Fixed VS2019 Code Analysis warnings, saying: > warning C26495: Variable 'm_PositionIndex' is uninitialized. > Always initialize a member variable (type.6) Also added in-class default member initializers to three other data members that were not yet initialized by the default-constructors of ImageConstIteratorWithIndex and ImageConstIteratorWithOnlyIndex. Note that `ImageConstIteratorWithIndex<TImage>` and `ImageConstIteratorWithIndex<TImage>` are rather "expensive" classes (having a virtual table) and their default-constructors are already non-trivial, so the extra cost of the added initialization appears relatively low.
github-actions
Bot
added
area:Core
dzenanz
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed VS2019 Code Analysis warnings, saying:
Also added in-class default member initializers to three other data members that were not yet initialized by the default-constructors of ImageConstIteratorWithIndex and ImageConstIteratorWithOnlyIndex.
Note that
ImageConstIteratorWithIndex<TImage>andImageConstIteratorWithIndex<TImage>are rather "expensive" classes (having a virtual table) and their default-constructors are already non-trivial, so the extra cost of the added initialization appears relatively low.