Skip to content

STYLE: Add missing braces to the substatements of for loops#3883

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Add-missing-braces-to-substatements-of-for-loops
Jan 23, 2023
Merged

STYLE: Add missing braces to the substatements of for loops#3883
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Add-missing-braces-to-substatements-of-for-loops

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

@N-Dekker N-Dekker commented Jan 20, 2023

Ran Notepad++ v8.4.8, Replace in Files, using Regular expression:

Find what: ^  ([ ]*)(for \(.+\)\r\n)\1    ([^ {].*;)\r\n
Replace with: $1  $2$1  {\r\n$1    $3\r\n$1  }\r\n

Follow-up to pull request #3875 commit 8d12282
"STYLE: Add missing braces to the substatements of if statements"

Ran Notepad++ v8.4.8, Replace in Files, using Regular expression:

    Find what: ^  ([ ]*)(for \(.+\)\r\n)\1    ([^ {].*;)\r\n
    Replace with: $1  $2$1  {\r\n$1    $3\r\n$1  }\r\n

Follow-up to pull request InsightSoftwareConsortium#3875
commit 8d12282
"STYLE: Add missing braces to the substatements of `if` statements"
@github-actions github-actions Bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Jan 20, 2023
@N-Dekker N-Dekker marked this pull request as ready for review January 20, 2023 22:58
@N-Dekker N-Dekker requested a review from jhlegarreta January 23, 2023 13:41
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Niels. I would have preferred a script to be able to re-use it (e.g. across remotes, etc.), but it is already good to have this done in the code base !

@dzenanz dzenanz merged commit 57624fd into InsightSoftwareConsortium:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants