Skip to content

Remove initial << insertion of the form Macro(<< "...) from itk macro calls#4059

Merged
dzenanz merged 4 commits intoInsightSoftwareConsortium:masterfrom
N-Dekker:Remove-initial-insertions-itkGenericExceptionMacro
Jun 2, 2023
Merged

Remove initial << insertion of the form Macro(<< "...) from itk macro calls#4059
dzenanz merged 4 commits intoInsightSoftwareConsortium:masterfrom
N-Dekker:Remove-initial-insertions-itkGenericExceptionMacro

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

@N-Dekker N-Dekker commented Jun 1, 2023

Follow-up to pull request #4057 commit 89beb04
"STYLE: Remove initial << insertion from itkExceptionMacro(<< " calls"

@N-Dekker
STYLE: Remove initial << from itkGenericExceptionMacro(<< " calls
f0653f8 
Follow-up to pull request InsightSoftwareConsortium#4057
commit 89beb04
"STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls"
@github-actions github-actions Bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) area:Numerics Issues affecting the Numerics module labels Jun 1, 2023
@N-Dekker
Copy link
Copy Markdown
Contributor Author

N-Dekker commented Jun 2, 2023

A test failure from MacOS at https://open.cdash.org/test/1094835957

Test: itkNiftiReadWriteDirectionSmallVoxelTest (Failed)
Build: Darwin-Build9995-PR4059-Remove-initial-insertions-itkGenericExceptionMacro (Azure.Mac-1685630864610) on 2023-06-01 14:50:27


Trying itk::WriteImage(inputImageNoSform, testFilename)
ITK test driver caught an ITK exception:

itk::ImageFileReaderException (0x7fce78d04630)
Location: "unknown" 
File: /Users/runner/work/1/s/Modules/IO/ImageBase/include/itkImageFileReader.hxx
Line: 135
Description:  Could not create IO object for reading file /Users/runner/work/1/s-build/Testing/Temporary/ITKIONIFTI/test_filled_sform.nii.gz
  Tried to create one of the following:
    MetaImageIO
    GDCMImageIO
    JPEGImageIO
    VTKImageIO
    PNGImageIO
    TIFFImageIO
    BMPImageIO
    NrrdImageIO
    GiplImageIO
    NiftiImageIO
  You probably failed to set a file suffix, or
    set the suffix to an unsupported type.

N-Dekker added 3 commits June 2, 2023 10:59
@N-Dekker
STYLE: Remove initial << insertion from itkDebugMacro(<< " calls
e2008ae 
Follow-up to pull request InsightSoftwareConsortium#4057
commit 89beb04
"STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls"

Aims to shorten the code a little bit, and improve consistency. The code base
already had more than 500 `itkDebugMacro` calls that passed a literal string as
first argument directly, without having `<<` at its left side.
@N-Dekker
STYLE: Remove initial << insertion from itkWarningMacro(<< " calls
d737e4f 
Follow-up to pull request InsightSoftwareConsortium#4057
commit 89beb04
"STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls"

Aims to shorten the code a little bit, and improve consistency. The code base
already had more than 80 `itkWarningMacro` calls that passed a literal string as
first argument directly, without having `<<` at its left side.
@N-Dekker
STYLE: Remove initial << from itkGenericOutputMacro(<< " calls
098c247 
Follow-up to pull request InsightSoftwareConsortium#4057
commit 89beb04
"STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls"

Aims to shorten the code a little bit, and improve consistency. The code base
already had seven `itkGenericOutputMacro` calls that passed a literal string as
first argument directly, without having `<<` at its left side.
@github-actions github-actions Bot added area:Registration Issues affecting the Registration module area:Video Issues affecting the Video module labels Jun 2, 2023
@N-Dekker N-Dekker marked this pull request as ready for review June 2, 2023 12:31
@N-Dekker N-Dekker changed the title STYLE: Remove initial << from itkGenericExceptionMacro(<< " calls Remove initial << insertion of the form Macro(<< "...) from itk macro calls Jun 2, 2023
@dzenanz dzenanz merged commit 30ef873 into InsightSoftwareConsortium:master Jun 2, 2023
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Jun 5, 2023
@N-Dekker
STYLE: Remove initial << insertion from Macro(<< "...) calls
25226f8 
Following ITK pull request InsightSoftwareConsortium/ITK#4059 "Remove initial `<<` insertion of the form `Macro(<< "`...`)` from itk macro calls"
@N-Dekker N-Dekker mentioned this pull request Jun 5, 2023
Merged
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Jun 5, 2023
@N-Dekker
STYLE: Remove initial << insertion from Macro(<< "...) calls
22b487b 
Following ITK pull request InsightSoftwareConsortium/ITK#4059 "Remove initial `<<` insertion of the form `Macro(<< "`...`)` from itk macro calls"
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Jun 6, 2023
@N-Dekker
STYLE: Remove initial << insertion from Macro(<< "...) calls
09cdfe9 
Following ITK pull request InsightSoftwareConsortium/ITK#4059 "Remove initial `<<` insertion of the form `Macro(<< "`...`)` from itk macro calls"
@N-Dekker N-Dekker mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Video Issues affecting the Video module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@N-Dekker @dzenanz