Skip to content

WIP: DO NOT MERGE: ENH: Handle IPP/IOP/PixelSpacing for SC#4120

Closed
issakomi wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
issakomi:test_sc
Closed

WIP: DO NOT MERGE: ENH: Handle IPP/IOP/PixelSpacing for SC#4120
issakomi wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
issakomi:test_sc

Conversation

@issakomi
Copy link
Copy Markdown
Member

@issakomi issakomi commented Jul 20, 2023

The PR is to run tests with changes in the upstream PR malaterre/GDCM#158

Closes #4109

Replaces #4111

@github-actions github-actions Bot added the area:ThirdParty Issues affecting the ThirdParty module label Jul 20, 2023
@jcfr
Copy link
Copy Markdown
Contributor

jcfr commented Jul 20, 2023

Thanks for working on this 💯

If possible, I suggest to include the following trailer in the commit:

Co-authored-by: Steve Pieper <pieper@isomics.com>

Thanks for considering 🙏

@issakomi
Copy link
Copy Markdown
Member Author

If possible, I suggest to include the following trailer in the commit:

Co-authored-by: Steve Pieper <pieper@isomics.com>

I have added Co-authored-by to the upstream PR malaterre/GDCM#158
I am not sure that the PR will be accepted by GDCM, s. post.
This one was just to run the tests.
CC @pieper

Screenshot 2023-07-20 at 17-06-37 ENH Handle IPP_IOP_PixelSpacing for SC by issakomi · Pull Request #158 · malaterre_GDCM

@jcfr
Copy link
Copy Markdown
Contributor

jcfr commented Jul 20, 2023

I have added Co-authored-by to the upstream PR

Outstanding. 🙏

not sure that the PR will be accepted by GDCM

🤞

@pieper
Copy link
Copy Markdown
Contributor

pieper commented Jul 20, 2023

Thank you @issakomi - this looks like a much more complete solution.

@issakomi
Copy link
Copy Markdown
Member Author

S. malaterre/GDCM#158

@issakomi issakomi closed this Jul 26, 2023
@issakomi issakomi deleted the test_sc branch May 5, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ThirdParty Issues affecting the ThirdParty module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GDCM ignores image geometry in secondary captures

3 participants