COMP: Wrapping of VectorContainer and DefaultStaticMeshTraits#442
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Jan 25, 2019
Merged
Conversation
Address the runtime warnings: Template itk::VectorContainer<unsignedchar,signedshort> already defined as <class 'itkVectorContainerPython.itkVectorContainerUCSS'> is redefined as <class 'itkVectorContainerPython.itkVectorContainerUCSS'> Warning: template already defined 'itk::VectorContainer<unsignedchar,signedshort>' Template itk::VectorContainer<unsignedlonglong,unsignedchar> already defined as <class 'itkVectorContainerPython.itkVectorContainerULLUC'> is redefined as <class 'itkVectorContainerPython.itkVectorContainerULLUC'> Warning: template already defined 'itk::VectorContainer<unsignedlonglong,unsignedchar>' Template itk::VectorContainer<unsignedchar,unsignedchar> already defined as <class 'itkVectorContainerPython.itkVectorContainerUCUC'> is redefined as <class 'itkVectorContainerPython.itkVectorContainerUCUC'> Warning: template already defined 'itk::VectorContainer<unsignedchar,unsignedchar>' Warning: Unknown parameter 'itk::DefaultStaticMeshTraits< double,2,2,double,double,double >' in template 'itk::PointSet' Warning: Unknown parameter 'itk::DefaultStaticMeshTraits< double,3,3,double,double,double >' in template 'itk::PointSet' by removing duplicate instantiations and adding the missing ones. This is a follow-up to 443955f
fbudin69500
reviewed
Jan 24, 2019
| itk_wrap_template("${ITKM_IT}${ITKM_${t}}" "${ITKT_IT},${ITKT_${t}}") | ||
| itk_wrap_template("${ITKM_UC}${ITKM_${t}}" "${ITKT_UC},${ITKT_${t}}") | ||
| # These are wrapped below with "vectypes" | ||
| if(NOT ${t} STREQUAL "UC") |
Contributor
There was a problem hiding this comment.
why is "UC" not wrapped? I don't see anywhere else where it is wrapped in this file.
Member
Author
There was a problem hiding this comment.
UC is wrapped here: https://github.com/InsightSoftwareConsortium/ITK/pull/442/files#diff-f6ed0a76b0d14eeb12481dde620b2ef6L30
If it was not wrapped, a build error or warning would result.
Member
Author
|
CircleCI warnings were addressed by @phcerdan in #446 . Merging to prepare for ITK 5 RC 1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the runtime warnings:
Template itk::VectorContainer<unsignedchar,signedshort>
already defined as <class 'itkVectorContainerPython.itkVectorContainerUCSS'>
is redefined as <class 'itkVectorContainerPython.itkVectorContainerUCSS'>
Warning: template already defined 'itk::VectorContainer<unsignedchar,signedshort>'
Template itk::VectorContainer<unsignedlonglong,unsignedchar>
already defined as <class 'itkVectorContainerPython.itkVectorContainerULLUC'>
is redefined as <class 'itkVectorContainerPython.itkVectorContainerULLUC'>
Warning: template already defined 'itk::VectorContainer<unsignedlonglong,unsignedchar>'
Template itk::VectorContainer<unsignedchar,unsignedchar>
already defined as <class 'itkVectorContainerPython.itkVectorContainerUCUC'>
is redefined as <class 'itkVectorContainerPython.itkVectorContainerUCUC'>
Warning: template already defined 'itk::VectorContainer<unsignedchar,unsignedchar>'
Warning: Unknown parameter 'itk::DefaultStaticMeshTraits< double,2,2,double,double,double >' in template 'itk::PointSet'
Warning: Unknown parameter 'itk::DefaultStaticMeshTraits< double,3,3,double,double,double >' in template 'itk::PointSet'
by removing duplicate instantiations and adding the missing ones.
This is a follow-up to 443955f