Global variable global synchronization#451
Closed
fbudin69500 wants to merge 1 commit intoInsightSoftwareConsortium:python-buildsfrom
Closed
Global variable global synchronization#451fbudin69500 wants to merge 1 commit intoInsightSoftwareConsortium:python-buildsfrom
fbudin69500 wants to merge 1 commit intoInsightSoftwareConsortium:python-buildsfrom
Conversation
fbudin69500
changed the title
Contributor
Author
|
The problem on Windows could be the different conditions used on Windows, here: and here: Although the two patches introducing the conditions are pretty old (8 months and 10 months). It is surprising that this has not caused an issue so far if this is indeed the root of the problem. |
thewtex
requested changes
Jan 29, 2019
Member
thewtex
left a comment
thewtex
left a comment
There was a problem hiding this comment.
Looking good!
A few inline comments.
Please rebase on master.
fbudin69500
force-pushed
the
global_variable_global_synchronization
branch
5 times, most recently
from
4ada86c to
d62c059
Compare
Replaces individual synchronization mechanisms across modules for each global variables used in ITK by a central mechanism in which all these variables are registered and which gives a single entry point to synchronize all global variables. Global variables are registered in a map, with a key that is their name and a value that is a pair of their pointer and a pointer to a synchronization function. The synchronization function will be called to synchronize these global variables across the different modules. Different global variables may have different synchronization functions: Some variables will just override the previous value in all modules whereas some others will need to actually synchronize their values. Several macros defined in `itkSingletonMacro.h` facilitate the usage of the new mechanism. A few static global variables have yet to be integrated to this mechanism. This included static variables defined in: * itkTransformFactoryBase.h * itkSpatialObjectFactoryBase.h * itkFEMFactoryBase.h * itkCurvatureNDAnisotropicDiffusionFunction.h * itkLevelSetFunction.h This list is not exhaustive and more global variables can be found with the following command line in bash: grep -r 'static '|grep m_ |grep -v ThirdParty |grep -v Review | grep -v const
fbudin69500
force-pushed
the
global_variable_global_synchronization
branch
from
d62c059 to
a66337e
Compare
Contributor
Author
|
On Windows, building ITK with MSVC++ 2017 with Python ON, and static libraries, the Python tests successfully pass. |
Member
|
Are any additional tests needed? |
Contributor
Author
|
Not to my knowledge, although anybody who wants to test this patch locally is more than welcome to do so and report the results here. |
thewtex
approved these changes
Feb 15, 2019
thewtex
changed the title
Member
|
Merged in #118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces individual synchronization mechanisms across modules for each global
variables used in ITK by a central mechanism in which all these variables
are registered and which gives a single entry point to synchronize
all global variables.
Global variables are registered in a map, with a key that is their name and
a value that is a pair of their pointer and a pointer to a synchronization
function. The synchronization function will be called to synchronize
these global variables across the different modules. Different global
variables may have different synchronization functions: Some variables
will just override the previous value in all modules whereas some
others will need to actually synchronize their values.
Change-Id: Ib6ebc9b3f9acd93ce8319f00579f6bf4982ca6b8