COMP: Use signed char for SobelOperator convolution test#4531
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Mar 21, 2024
Merged
Conversation
github-actions
Bot
added
type:Compiler
dzenanz
approved these changes
Mar 20, 2024
Member
Author
|
/azp run ITK.macOS |
In 03c8176 a concept check was added that the sobel operator uses a signed pixel type. On Linux aarch64, ❯ c++ --version c++ (Debian 12.2.0-14) 12.2.0 ❯ uname -a Linux deb 6.1.0-18-arm64 #1 SMP Debian 6.1.76-1 (2024-02-01) aarch64 GNU/Linux char is unsigned, which causes the concept check to fail. Switch `char` to `signed char`.
thewtex
force-pushed
the
linux-arm-sobel-pixel-type
branch
from
eaa6870 to
3253507
Compare
phcerdan
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 03c8176 a concept check was added
that the sobel operator uses a signed pixel type. On Linux aarch64,
❯ c++ --version
c++ (Debian 12.2.0-14) 12.2.0
❯ uname -a
Linux deb 6.1.0-18-arm64 #1 SMP Debian 6.1.76-1 (2024-02-01) aarch64 GNU/Linux
char is unsigned, which causes the concept check to fail. Switch
charto
signed char.