COMP: Use default copy and move construct and assign in itk::Region

[jhlegarreta]

Use the compiler-proved default implementations for itk::Region copy constructor, copy assignment, move constructor, and move assignment functions.

As noted in [1], the C++ standard deprecated the implicit generation of copy and assignment operators.

Fixes:

[CTest: warning matched] /Users/builder/externalModules/Core/Common/include/itkRegion.h:91:11:
 warning: definition of implicit copy assignment operator for 'Region' is deprecated because it has a user-declared destructor [-Wdeprecated]
  virtual ~Region() = default;
          ^
[CTest: warning matched] /Users/builder/externalModules/Core/Common/include/itkImageIORegion.h:117:30:
 note: in implicit copy assignment operator for 'itk::Region' first required here
  operator=(Self &&) = default;
                             ^
[CTest: warning matched] /Users/builder/externalModules/IO/ImageBase/include/itkImageIOBase.h:228:3:
 note: in implicit move assignment operator for 'itk::ImageIORegion' first required here
  itkSetMacro(IORegion, ImageIORegion);
  ^
[CTest: warning matched] /Users/builder/externalModules/Core/Common/include/itkMacro.h:992:22:
 note: expanded from macro 'itkSetMacro'
      this->m_##name = std::move(_arg);                        \
                     ^

And other similar warnings stemming from itk::Region that have been appearing consistently in some macOS site builds in the dashboard: https://open.cdash.org/viewBuildError.php?type=1&buildid=9579479

[1] https://learn.microsoft.com/bs-latn-ba/cpp/error-messages/compiler-warnings/c5267?view=msvc-150#remarks

PR Checklist

• No API changes were made (or the changes have been approved)
• No major design changes were made (or the changes have been approved)

[jhlegarreta]

@seanm Hopefully this will remove some of the 199 warnings on RogueResearch22.

[seanm]

Cool, thanks! I defer to C++ experts on the correctness of this change, but seems reasonable to me!

[N-Dekker]

I'm sorry I think Region should remain copyable, as long as it is being used as base class of ImageRegion 🤷

• For the record, in the future, ImageRegion hopefully no longer inherits from Region: pull request PERF: Make ImageRegion trivially copyable, remove inheritance (ITK_FUTURE_LEGACY_REMOVE) #4344

It's a bit cumbersome, but I guess the warnings will go away by adding four of those "explicitly defaulted" member functions to the public section:

Region(const Region &) = default;
Region(Region &&) = default;
Region& operator=(const Region &) = default;
Region& operator=(Region &&) = default;

[jhlegarreta]

#4627 (comment) 👍 Done. Thanks Niels.

[jhlegarreta]

/azp run ITK.Windows

[N-Dekker]

Does it indeed fix the warnings? I guess so, but you never know... anyway, approved, of course. 👍 Thanks Jon!