Skip to content

BUG: Remove check for nullptr after new#4801

Merged
blowekamp merged 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp:ge_io_no_null_check
Aug 14, 2024
Merged

BUG: Remove check for nullptr after new#4801
blowekamp merged 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp:ge_io_no_null_check

Conversation

@blowekamp
Copy link
Copy Markdown
Member

@blowekamp blowekamp commented Aug 13, 2024

"new" throws an exception when it fails.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@blowekamp
BUG: Remove check for nullptr after new
f981943 
"new" throws an exception when it fails.
@github-actions github-actions Bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances area:IO Issues affecting the IO module labels Aug 13, 2024
N-Dekker
N-Dekker approved these changes Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@N-Dekker N-Dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Nice follow-up to pull request #3619 commit d004710 😃 Thanks Bradley!

@blowekamp blowekamp marked this pull request as ready for review August 14, 2024 13:36
@blowekamp blowekamp merged commit 333f949 into InsightSoftwareConsortium:master Aug 14, 2024
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
@blowekamp
Merge pull request InsightSoftwareConsortium#4801 from blowekamp/ge_i…
41577fc 
…o_no_null_check

BUG: Remove check for nullptr after new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

@N-Dekker N-Dekker N-Dekker approved these changes

Assignees

No one assigned

Labels

area:IO Issues affecting the IO module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blowekamp @hjmjohnson @dzenanz @N-Dekker