BUG: GHA: Cancel-in-progress event if not the same head SHA#5042
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Dec 11, 2024
Merged
Conversation
github-actions
bot
added
type:Bug
Grouping based on github.event.pull_request.head.sha, i.e. "the commit ID for the last commit to the head branch of the pull request" only cancels commits with the same SHA. With this PR, on-going workflows of the same PR would be cancelled.
SimonRit
force-pushed
the
cancel-in-progress
branch
from
4115af5 to
fea796d
Compare
SimonRit
changed the title
Member
|
Can we test this with a force push/update on this branch? |
Member
|
Simon already made a force-push, which seems to cause cancellations: https://github.com/InsightSoftwareConsortium/ITK/actions/runs/12280142773/job/34265846027 |
hjmjohnson
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouping based on github.event.pull_request.head.sha, i.e. "the commit ID for the last commit to the head branch of the pull request" only cancels commits with the same SHA. With this PR, on-going workflows of the same PR would be cancelled.
See #5019 (comment).
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.