Skip to content

ENH: Add a PrintHelper file to overload vector printing.#512

Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:EnhancePrintingCapabilities
Mar 2, 2019
Merged

ENH: Add a PrintHelper file to overload vector printing.#512
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:EnhancePrintingCapabilities

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta commented Feb 16, 2019 •
edited
Loading

Add a new itkPrintHelper.h file to help in printing std::vectors.

Change-Id: I2306c8bf44cd0cec9661c3515c0a77cfbc34ea88

@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Feb 16, 2019

Supersedes #103.

@jhlegarreta jhlegarreta mentioned this pull request Feb 16, 2019
Closed
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Feb 16, 2019

Looks like std::vector is not used that much, and not sure why itk::Vector is not used in these cases...

@jhlegarreta jhlegarreta mentioned this pull request Feb 16, 2019
Closed
phcerdan
phcerdan reviewed Feb 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@phcerdan phcerdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for tackling it.
I think for the namespace name, print_helper sounds better than to_string? ! to_string is clearer for a function though. Just a matter of... naming is hard.

@jhlegarreta jhlegarreta force-pushed the EnhancePrintingCapabilities branch from c18eccb to a7b5a2b Compare February 19, 2019 04:18
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Feb 19, 2019

@phcerdan looks sensible. Done in a7b5a2b.

@jhlegarreta jhlegarreta added the type:Enhancement Improvement of existing methods or implementation label Feb 23, 2019
@jhlegarreta jhlegarreta force-pushed the EnhancePrintingCapabilities branch 2 times, most recently from 2e14848 to fe3cb78 Compare February 23, 2019 03:47
@jhlegarreta
ENH: Add a PrintHelper file to overload boolean and vector printing.
548fc18 
Add a new `itkPrintHelper.h` file to help in printing std::vectors.

Change-Id: I2306c8bf44cd0cec9661c3515c0a77cfbc34ea88
@jhlegarreta jhlegarreta force-pushed the EnhancePrintingCapabilities branch from fe3cb78 to 548fc18 Compare February 23, 2019 04:17
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Feb 24, 2019

I've checked the output of the tests and the change is working 👍 .
Thanks for the support and patience.

@jhlegarreta jhlegarreta changed the title ENH: Add a PrintHelper file to overload boolean and vector printing. ENH: Add a PrintHelper file to overload vector printing. Feb 24, 2019
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Feb 24, 2019

The overload to print booleans as On/Off will come hopefully at some point in another PR.

@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Feb 24, 2019

Issue opened at #537 .

@hjmjohnson hjmjohnson merged commit 94463ea into InsightSoftwareConsortium:master Mar 2, 2019
@jhlegarreta jhlegarreta deleted the EnhancePrintingCapabilities branch March 2, 2019 13:57
Copilot AI mentioned this pull request Nov 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

@phcerdan phcerdan phcerdan approved these changes

@thewtex thewtex Awaiting requested review from thewtex

@blowekamp blowekamp Awaiting requested review from blowekamp

@fbudin69500 fbudin69500 Awaiting requested review from fbudin69500

Assignees

No one assigned

Labels

type:Enhancement Improvement of existing methods or implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jhlegarreta @hjmjohnson @dzenanz @phcerdan