Skip to content

BUG: Use pip to install cmake for release#52

Closed
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp:UsePipToInstallCMake-for-release-only
Closed

BUG: Use pip to install cmake for release#52
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp:UsePipToInstallCMake-for-release-only

Conversation

@blowekamp
Copy link
Copy Markdown
Member

scikit-ci-addons intall_cmake explicitly fails with CircleCI
2.0. Revert to pip install cmake.

ref: scikit-build/scikit-ci-addons#69

scikit-ci-addons intall_cmake explicitly fails with CircleCI
2.0. Revert to `pip install cmake`.

Change-Id: Id5e30d53878b88be51e00fa40a927b3fa05fa5a9
@blowekamp blowekamp force-pushed the UsePipToInstallCMake-for-release-only branch from 605d13b to e8dfb0a Compare July 30, 2018 13:20
Comment thread .circleci/config.yml
sudo pip install --upgrade pip
sudo pip install scikit-ci-addons
ci_addons circle/install_cmake.py 3.7.2
sudo pip install cmake==3.7.2 scikit-ci-addons
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, since rsync is already installed, having:

sudo pip install -U scikit-ci-addons
ci_addons circle/install_cmake.py 3.7.2

would also work now.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke in the 0.21.0 release. Is it expect to be fixed is a patch release?

@thewtex
Copy link
Copy Markdown
Member

thewtex commented Jul 31, 2018

This has been merged.

@thewtex thewtex closed this Jul 31, 2018
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
Resampling is now a separate, streamable filter
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
Also enable pair-wise test for all ground truth tests.

Summary results (below) suggest presence of bias in sub-pixel peak estimation:

PeakInterpolation 0 has average translation bias: -0.040 -0.028
PeakInterpolation 1 has average translation bias: -0.035 -0.025
PeakInterpolation 2 has average translation bias: -0.038 -0.027
Average translation error for padding method 2: 0.194
Test InsightSoftwareConsortium#52: itkMontageGroundTruthRun10-129 ..............***Failed    2.33 sec

PeakInterpolation 0 has average translation bias: -0.011 -0.017
PeakInterpolation 1 has average translation bias: -0.009 -0.014
PeakInterpolation 2 has average translation bias: -0.010 -0.016
Average translation error for padding method 2: 0.162
Test InsightSoftwareConsortium#54: itkMontageGroundTruthRunrun2 ................   Passed    1.58 sec

PeakInterpolation 0 has average translation bias: 0.021 -0.010
PeakInterpolation 1 has average translation bias: 0.019 -0.009
PeakInterpolation 2 has average translation bias: 0.020 -0.010
Average translation error for padding method 2: 0.172
Test InsightSoftwareConsortium#56: itkMontageGroundTruthRunMediumCarbonSteel ...***Failed    3.49 sec

PeakInterpolation 0 has average translation bias: 0.104 0.303 -0.040
PeakInterpolation 1 has average translation bias: 0.104 0.302 -0.041
PeakInterpolation 2 has average translation bias: 0.104 0.303 -0.041
Average translation error for padding method 2: 0.306
Test InsightSoftwareConsortium#70: itkMontageGroundTruthRunDzZ_T1 ..............***Failed   19.56 sec

PeakInterpolation 0 has average translation bias: 1.065 1.733
PeakInterpolation 1 has average translation bias: 1.066 1.734
PeakInterpolation 2 has average translation bias: 1.065 1.733
Average translation error for padding method 2: 1.811
Test InsightSoftwareConsortium#79: itkMontageGroundTruthRunTiles ...............***Failed   10.31 sec
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
…-MultiThreaderType-with-MultiThreaderBase

COMP: Use `MultiThreaderBase` directly, instead of `MultiThreaderType`
hjmjohnson pushed a commit that referenced this pull request Apr 25, 2026
Resampling is now a separate, streamable filter
hjmjohnson pushed a commit that referenced this pull request Apr 25, 2026
Also enable pair-wise test for all ground truth tests.

Summary results (below) suggest presence of bias in sub-pixel peak estimation:

PeakInterpolation 0 has average translation bias: -0.040 -0.028
PeakInterpolation 1 has average translation bias: -0.035 -0.025
PeakInterpolation 2 has average translation bias: -0.038 -0.027
Average translation error for padding method 2: 0.194
Test #52: itkMontageGroundTruthRun10-129 ..............***Failed    2.33 sec

PeakInterpolation 0 has average translation bias: -0.011 -0.017
PeakInterpolation 1 has average translation bias: -0.009 -0.014
PeakInterpolation 2 has average translation bias: -0.010 -0.016
Average translation error for padding method 2: 0.162
Test #54: itkMontageGroundTruthRunrun2 ................   Passed    1.58 sec

PeakInterpolation 0 has average translation bias: 0.021 -0.010
PeakInterpolation 1 has average translation bias: 0.019 -0.009
PeakInterpolation 2 has average translation bias: 0.020 -0.010
Average translation error for padding method 2: 0.172
Test #56: itkMontageGroundTruthRunMediumCarbonSteel ...***Failed    3.49 sec

PeakInterpolation 0 has average translation bias: 0.104 0.303 -0.040
PeakInterpolation 1 has average translation bias: 0.104 0.302 -0.041
PeakInterpolation 2 has average translation bias: 0.104 0.303 -0.041
Average translation error for padding method 2: 0.306
Test #70: itkMontageGroundTruthRunDzZ_T1 ..............***Failed   19.56 sec

PeakInterpolation 0 has average translation bias: 1.065 1.733
PeakInterpolation 1 has average translation bias: 1.066 1.734
PeakInterpolation 2 has average translation bias: 1.065 1.733
Average translation error for padding method 2: 1.811
Test #79: itkMontageGroundTruthRunTiles ...............***Failed   10.31 sec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants