STYLE: Use C++17 nested namespace syntax#5407
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Jun 17, 2025
Merged
STYLE: Use C++17 nested namespace syntax#5407hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
Replace nested namespaces such as 'namespace a { namespace b { ... } }'
and changes to the more concise syntax introduced in C++17:
'namespace a::b { ... }'.
Inline namespaces are not modified.
Disabled KWStyle Namespace checking that is incapable of
supporting the c++17 nested namespace formatting.
hjmjohnson
added
the
type:Style
Member
Author
|
This is a style proposal to make use of the C++17 formatted nested namespace conventions. I think that this compact format is much easier to read and maintain. It does require disabling the KWStyle Namespace checking, because that checker does not support nested namespaces. Perhaps it would be easy to update KWStyle to accept "itk [:]+." instead of the exact "itk" string. |
hjmjohnson
changed the title
Member
Author
|
Thanks @dzenanz , @N-Dekker , @blowekamp for your support. Given no identification of concerns, I'll leave this open until later this afternoon, then merge if no other responses come through. |
hjmjohnson
changed the title
thewtex
approved these changes
Jun 17, 2025
hjmjohnson
merged commit 5027238
into
InsightSoftwareConsortium:master
16 checks passed
Contributor
|
Do you make this change with a linter tool? Manually? Custom script? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace nested namespaces such as 'namespace a { namespace b { ... } }' and changes to the more concise syntax introduced in C++17: 'namespace a::b { ... }'.
Inline namespaces are not modified.
Disabled KWStyle Namespace checking that is incapable of supporting the c++17 nested namespace formatting.
PR Checklist