STYLE: Replace Allocate(); FillBuffer({}) with AllocateInitialized()

[N-Dekker]

Replaced lines of code of the form

image->Allocate();
image->FillBuffer(PixelType{});

With image->AllocateInitialized();.

Using Notepad++, Replace in Files, doing:

Find what: (.+->)Allocate\(\);[\r\n]+\1FillBuffer\(.*{}\);
Replace with: $1AllocateInitialized\(\);

• Follow-up to pull request STYLE: Replace Allocate(); FillBuffer(0) with AllocateInitialized() #4494

[hjmjohnson]

Very nice. Approved when CI passes.

[dzenanz]

Are there any instances of AllocateInitialized() soon followed by FillBuffer()? If so, we could turn those into Allocate(false) to avoid double initialization.

[N-Dekker]

Are there any instances of AllocateInitialized() soon followed by FillBuffer()? If so, we could turn those into Allocate(false) to avoid double initialization.

Do you mean, specifically when FillBuffer(fillValue) is called with a non-zero fill-value?

[dzenanz]

Yes.

[N-Dekker]

I think there are still a few unnecessary FillBuffer(<zero>) calls that I would like to address, once this PR is processed. (With this PR I only addressed fill values specified by braces, {}.) Once these are addressed, yes, let's look at unnecessary double initializations 👍

[N-Dekker]

Are there any instances of AllocateInitialized() soon followed by FillBuffer()? If so, we could turn those into Allocate(false) to avoid double initialization.

@dzenanz No instances found, using Notepad++ Find in Files, with the following regular expression: ^( .+)AllocateInitialized\(\);[\r\n]+\1FillBuffer Did you see any instance like that?

[dzenanz]

I didn't, I was just wondering if there are any.