Replace Allocate(); FillBuffer(0) with AllocateInitialized(), remove two more FillBuffer(0) calls#5584
Merged
hjmjohnson merged 3 commits intoInsightSoftwareConsortium:mainfrom Nov 2, 2025
Conversation
github-actions
Bot
added
type:Testing
hjmjohnson
approved these changes
Oct 31, 2025
Member
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
Looks good at a glance. Approved when CI passes.
dzenanz
approved these changes
Oct 31, 2025
Member
|
@N-Dekker Mark it "ready for review"? |
AllocateInitialized() already zero-initializes the buffer.
Found by searching for `FillBuffer(0)` in *.py files. Follow-up to pull request InsightSoftwareConsortium#4494 commit cd49925 "STYLE: Replace `Allocate(); FillBuffer(0)` with `AllocateInitialized()`"
Using Notepad++, Replace in Files, doing: Find what: `^( .+)Allocate\(\);[\r\n]+\1FillBuffer\(0\);` Find what: `^( .+)Allocate\(\);[\r\n]+\1FillBuffer\(0.0\); Replace with: `$1AllocateInitialized\(\);` Again, another follow-up to pull request InsightSoftwareConsortium#4494 commit cd49925 "STYLE: Replace `Allocate(); FillBuffer(0)` with `AllocateInitialized()`"
N-Dekker
force-pushed
the
AllocateInitialized-FillBuffer
branch
from
1e0500c to
da0bea5
Compare
github-actions
Bot
added
area:Python wrapping
Contributor
Author
It really needed another force-push (including a rebase, an amend and an extra commit), but now it is ready for review! Thanks for waiting! |
hjmjohnson
approved these changes
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocate(); FillBuffer(0)withAllocateInitialized()#4494Apparently my old pull request #4494 was far from being complete 🤷