-
-
Notifications
You must be signed in to change notification settings - Fork 726
Rwindows #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
muschellij2
wants to merge
66
commits into
InsightSoftwareConsortium:master
from
muschellij2:Rwindows
Closed
Rwindows #562
Changes from all commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
fd38b4d
COMP: for compiling with perf enhancements
stnava 4afbf73
COMP: for compiling with perf enhancements
stnava f44174c
COMP: for compiling with perf enhancements - forgot file add
stnava ccd1d4e
trying to get a windows build to work
muschellij2 e84f2b1
merged with stnava
muschellij2 41fb22d
Merged with upstream ITK
muschellij2 a9f5c6f
Merged with Insight UPstream
muschellij2 6adf864
COMP: for compiling with perf enhancements
stnava 9b2fff2
COMP: for compiling with perf enhancements - forgot file add
stnava e8010f4
Merge branch 'master' of https://github.com/stnava/ITK
stnava abc43ba
Merging with stnava
muschellij2 0e4fa23
Merging with ITK full branch
muschellij2 e820b29
Merge branch 'master' of https://itk.org/ITK
stnava 8b2880e
Merging with ITK main
muschellij2 2c571cb
STYLE: remove annoying warnings
stnava 0a7cfd3
Merge branch 'master' of https://itk.org/ITK
stnava e58141e
BUG: undo bad attempt at h5 fix
stnava a7944c2
Merge branch 'master' of https://itk.org/ITK
stnava f397baa
Merged with the up<BS> branch 'upstream/master'
muschellij2 a8eb21f
trying to get with ITK
muschellij2 66e7226
Merge branch 'master' of https://itk.org/ITK
stnava 20a456c
Merge branch 'master' of https://itk.org/ITK
stnava 8745264
merging with stnava
muschellij2 dc8765d
Merge pull request #1 from muschellij2/master
stnava 8bd5a3f
updated with Modules for VNL
muschellij2 1e36cb3
updated with Modules for VNL
muschellij2 1533db3
Merged with ITK
muschellij2 df1172e
got a Cannot find source file:
muschellij2 7bf3409
updated the cmakelists
muschellij2 f4727a4
removed vnl_matrix_fixed+double.1.1-.cxx"
muschellij2 186799e
removed 2.3- - should be good
muschellij2 a2ed118
Trying to merge with ITK
muschellij2 3ff7e8b
all merged
muschellij2 54f2a08
removed mod
muschellij2 fd3e82a
Merging with themaster
muschellij2 32c4123
Merged with main upstream
muschellij2 82f9d5e
Merge remote-tracking branch 'themaster/master'
muschellij2 ae617cc
Updated the merge
muschellij2 63b170e
Trying with HDF5 improvements
muschellij2 424d74a
Merging with ITK
muschellij2 6956711
adding ## to __VA_ARGS__
adigherman 84b4c7a
Trying upstream
muschellij2 6c4fdf1
Removed VCL_COMPILER_DETECTION_HEADER from the vcl_sources set
adigherman 5b163e2
Merging with the upstream
muschellij2 c19a4d5
needed a new fix for the HD and the vnl
muschellij2 3e51b2d
Merging with ITK
muschellij2 a47739c
updated the newline bs
muschellij2 ed152c1
I think the vlc compiler detection should be there
muschellij2 bfb3df4
merging with Adis
muschellij2 b567870
Merging with ITK masterMerge remote-tracking branch 'themaster/master'
muschellij2 5bf6430
Eigen3 still not fixed
muschellij2 200ac98
Merging with ITK top
muschellij2 fce0b64
Same as ITK now with windows fixesg branch 'themaster/master'
muschellij2 619c350
trying VCL_COMPILER_DETECTION_HEADER to be included
muschellij2 9509048
Merging with ITK master
muschellij2 5380a84
updated Cmake for ITK to fit in with other ITK environment variables
muschellij2 d9dd9c1
fixing whitespace crap
muschellij2 25d98ff
fixing whitespace crap
muschellij2 8409abb
fixing whitespace crap
muschellij2 2768aef
fixing whitespace crap
muschellij2 7bed0de
fixing vcl again
muschellij2 e10d3bc
fixing the linking again
muschellij2 77156ea
Merging with ITKMerge remote-tracking branch 'themaster/master'
muschellij2 5f768c2
ENH: Rwindows compatibility
muschellij2 7810196
WIP: merging with master
muschellij2 436045c
COMP: fixing Eigen3
muschellij2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the upstream version of this file fix this issue?
https://github.com/live-clones/hdf5/blob/master/src/H5win32defs.h#L46-L49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I believe so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually believe that this fixes it sufficiently without hte rest of the HDF5 changes as failures happen with
H5Defl.c:https://ci.appveyor.com/project/muschellij2/itkr/builds/23054691
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still is an issue, but I think we can bring up in new PR