Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
fd38b4d
COMP: for compiling with perf enhancements
stnava Sep 4, 2018
4afbf73
COMP: for compiling with perf enhancements
stnava Sep 4, 2018
f44174c
COMP: for compiling with perf enhancements - forgot file add
stnava Sep 4, 2018
ccd1d4e
trying to get a windows build to work
muschellij2 Oct 1, 2018
e84f2b1
merged with stnava
muschellij2 Oct 1, 2018
41fb22d
Merged with upstream ITK
muschellij2 Oct 9, 2018
a9f5c6f
Merged with Insight UPstream
muschellij2 Oct 10, 2018
6adf864
COMP: for compiling with perf enhancements
stnava Sep 4, 2018
9b2fff2
COMP: for compiling with perf enhancements - forgot file add
stnava Sep 4, 2018
e8010f4
Merge branch 'master' of https://github.com/stnava/ITK
stnava Oct 11, 2018
abc43ba
Merging with stnava
muschellij2 Oct 11, 2018
0e4fa23
Merging with ITK full branch
muschellij2 Oct 11, 2018
e820b29
Merge branch 'master' of https://itk.org/ITK
stnava Oct 13, 2018
8b2880e
Merging with ITK main
muschellij2 Oct 17, 2018
2c571cb
STYLE: remove annoying warnings
stnava Oct 17, 2018
0a7cfd3
Merge branch 'master' of https://itk.org/ITK
stnava Oct 17, 2018
e58141e
BUG: undo bad attempt at h5 fix
stnava Oct 17, 2018
a7944c2
Merge branch 'master' of https://itk.org/ITK
stnava Oct 17, 2018
f397baa
Merged with the up<BS> branch 'upstream/master'
muschellij2 Oct 17, 2018
a8eb21f
trying to get with ITK
muschellij2 Oct 17, 2018
66e7226
Merge branch 'master' of https://itk.org/ITK
stnava Oct 18, 2018
20a456c
Merge branch 'master' of https://itk.org/ITK
stnava Oct 18, 2018
8745264
merging with stnava
muschellij2 Oct 18, 2018
dc8765d
Merge pull request #1 from muschellij2/master
stnava Oct 18, 2018
8bd5a3f
updated with Modules for VNL
muschellij2 Oct 23, 2018
1e36cb3
updated with Modules for VNL
muschellij2 Oct 23, 2018
1533db3
Merged with ITK
muschellij2 Nov 1, 2018
df1172e
got a Cannot find source file:
muschellij2 Nov 1, 2018
7bf3409
updated the cmakelists
muschellij2 Nov 1, 2018
f4727a4
removed vnl_matrix_fixed+double.1.1-.cxx"
muschellij2 Nov 1, 2018
186799e
removed 2.3- - should be good
muschellij2 Nov 1, 2018
a2ed118
Trying to merge with ITK
muschellij2 Nov 2, 2018
3ff7e8b
all merged
muschellij2 Nov 5, 2018
54f2a08
removed mod
muschellij2 Nov 5, 2018
fd3e82a
Merging with themaster
muschellij2 Nov 8, 2018
32c4123
Merged with main upstream
muschellij2 Nov 15, 2018
82f9d5e
Merge remote-tracking branch 'themaster/master'
muschellij2 Jan 7, 2019
ae617cc
Updated the merge
muschellij2 Jan 10, 2019
63b170e
Trying with HDF5 improvements
muschellij2 Jan 14, 2019
424d74a
Merging with ITK
muschellij2 Jan 16, 2019
6956711
adding ## to __VA_ARGS__
adigherman Jan 16, 2019
84b4c7a
Trying upstream
muschellij2 Jan 17, 2019
6c4fdf1
Removed VCL_COMPILER_DETECTION_HEADER from the vcl_sources set
adigherman Jan 18, 2019
5b163e2
Merging with the upstream
muschellij2 Jan 29, 2019
c19a4d5
needed a new fix for the HD and the vnl
muschellij2 Jan 29, 2019
3e51b2d
Merging with ITK
muschellij2 Jan 29, 2019
a47739c
updated the newline bs
muschellij2 Jan 29, 2019
ed152c1
I think the vlc compiler detection should be there
muschellij2 Jan 30, 2019
bfb3df4
merging with Adis
muschellij2 Jan 30, 2019
b567870
Merging with ITK masterMerge remote-tracking branch 'themaster/master'
muschellij2 Feb 1, 2019
5bf6430
Eigen3 still not fixed
muschellij2 Feb 3, 2019
200ac98
Merging with ITK top
muschellij2 Feb 18, 2019
fce0b64
Same as ITK now with windows fixesg branch 'themaster/master'
muschellij2 Feb 21, 2019
619c350
trying VCL_COMPILER_DETECTION_HEADER to be included
muschellij2 Feb 21, 2019
9509048
Merging with ITK master
muschellij2 Feb 26, 2019
5380a84
updated Cmake for ITK to fit in with other ITK environment variables
muschellij2 Feb 27, 2019
d9dd9c1
fixing whitespace crap
muschellij2 Feb 27, 2019
25d98ff
fixing whitespace crap
muschellij2 Feb 27, 2019
8409abb
fixing whitespace crap
muschellij2 Feb 27, 2019
2768aef
fixing whitespace crap
muschellij2 Feb 27, 2019
7bed0de
fixing vcl again
muschellij2 Feb 27, 2019
e10d3bc
fixing the linking again
muschellij2 Feb 28, 2019
77156ea
Merging with ITKMerge remote-tracking branch 'themaster/master'
muschellij2 Feb 28, 2019
5f768c2
ENH: Rwindows compatibility
muschellij2 Feb 28, 2019
7810196
WIP: merging with master
muschellij2 Mar 5, 2019
436045c
COMP: fixing Eigen3
muschellij2 Mar 5, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/ThirdParty/Eigen3/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if(ITK_USE_SYSTEM_EIGEN)
set(Eigen3_DIR_INSTALL ${Eigen3_DIR})
set(Eigen3_DIR_BUILD ${Eigen3_DIR})
else()
set(Eigen3_DIR_INSTALL "${CMAKE_INSTALL_PREFIX}/${ITK_INSTALL_LIBRARY_DIR}/cmake/ITK-${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR}/Modules")
set(Eigen3_DIR_INSTALL "\${ITK_MODULES_DIR}")
set(Eigen3_DIR_BUILD "${CMAKE_CURRENT_BINARY_DIR}/src/itkeigen")
endif()

Expand Down
11 changes: 10 additions & 1 deletion Modules/ThirdParty/HDF5/src/itkhdf5/src/H5win32defs.h
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ typedef __int64 h5_stat_size_t;
* Also note that the variadic macro is using a VC++ extension
* where the comma is dropped if nothing is passed to the ellipsis.
*/
#define HDopen(S,F,...) _open(S, F | _O_BINARY, __VA_ARGS__)
#define HDread(F,M,Z) _read(F,M,Z)
#define HDrmdir(S) _rmdir(S)
#define HDsetvbuf(F,S,M,Z) setvbuf(F,S,M,(Z>1?Z:2))
Expand All @@ -68,6 +67,15 @@ typedef __int64 h5_stat_size_t;

#ifdef H5_HAVE_VISUAL_STUDIO

/* _O_BINARY must be set in Windows to avoid CR-LF <-> LF EOL
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the upstream version of this file fix this issue?

https://github.com/live-clones/hdf5/blob/master/src/H5win32defs.h#L46-L49

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I believe so.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually believe that this fixes it sufficiently without hte rest of the HDF5 changes as failures happen with H5Defl.c:

C:\run\ITKR.Rcheck\00_pkg_src\ITKR\src\itks\Modules\ThirdParty\HDF5\src\itkhdf5\src\H5Defl.c: In function 'H5D__efl_read':
C:\run\ITKR.Rcheck\00_pkg_src\ITKR\src\itks\Modules\ThirdParty\HDF5\src\itkhdf5\src\H5Defl.c:291:44: error: macro "HDopen" requires 3 arguments, but only 2 given
         if((fd = HDopen(full_name, O_RDONLY)) < 0)
                                            ^
C:\run\ITKR.Rcheck\00_pkg_src\ITKR\src\itks\Modules\ThirdParty\HDF5\src\itkhdf5\src\H5Defl.c:291:18: error: 'HDopen' undeclared (first use in this function)
         if((fd = HDopen(full_name, O_RDONLY)) < 0)
                  ^
C:\run\ITKR.Rcheck\00_pkg_src\ITKR\src\itks\Modules\ThirdParty\HDF5\src\itkhdf5\src\H5Defl.c:291:18: note: each undeclared identifier is reported only once for each function it appears in

https://ci.appveyor.com/project/muschellij2/itkr/builds/23054691

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still is an issue, but I think we can bring up in new PR

* transformations when performing I/O. Note that this will
* produce Unix-style text files, though.
*
* Also note that the variadic macro is using a VC++ extension
* where the comma is dropped if nothing is passed to the ellipsis.
*/
#define HDopen(S,F,...) _open(S, F | _O_BINARY, __VA_ARGS__)

#if (_MSC_VER < 1800)
#ifndef H5_HAVE_STRTOLL
#define HDstrtoll(S,R,N) _strtoi64(S,R,N)
Expand Down Expand Up @@ -150,6 +158,7 @@ extern "C" {
#define HDpthread_self_ulong() ((unsigned long)GetCurrentThreadId())

#ifndef H5_HAVE_MINGW
#define HDopen(S,F,M) _open(S, F | _O_BINARY, M)
#define HDftruncate(F,L) _chsize_s(F,L)
#define HDfseek(F,O,W) _fseeki64(F,O,W)
#endif /* H5_HAVE_MINGW */
Expand Down