Deprecate MultiThreaderType aliases, use MultiThreaderBase directly#5692
Merged
hjmjohnson merged 2 commits intoDec 16, 2025
Conversation
`ProcessObject::MultiThreaderType` and `ImageToImageMetric::MultiThreaderType` are always just aliases of `itk::MultiThreaderBase`, the common base class of PlatformMultiThreader, PoolMultiThreader, and TBBMultiThreader. So it appears clearer to just use MultiThreaderBase directly.
Asked users to use `itk::MultiThreaderBase` directly.
github-actions
Bot
added
area:Core
N-Dekker
commented
Dec 15, 2025
Comment on lines
-611
to
+615
| : m_WorkUnitInfo(static_cast<const typename MultiThreaderType::WorkUnitInfo *>(workunitInfoAsVoid)) | ||
| : m_WorkUnitInfo(static_cast<const MultiThreaderBase::WorkUnitInfo *>(workunitInfoAsVoid)) |
Contributor
Author
There was a problem hiding this comment.
Note that the typename keyword is not necessary for MultiThreaderBase::WorkUnitInfo 😃
dzenanz
approved these changes
Dec 15, 2025
hjmjohnson
approved these changes
Dec 16, 2025
N-Dekker
added a commit
to N-Dekker/ITKLabelErodeDilate
that referenced
this pull request
Jan 5, 2026
Following ITK pull request InsightSoftwareConsortium/ITK#5692 "Deprecate `MultiThreaderType` aliases, use `MultiThreaderBase` directly"
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 19, 2026
Following ITK pull request InsightSoftwareConsortium#5692 "Deprecate `MultiThreaderType` aliases, use `MultiThreaderBase` directly"
hjmjohnson
pushed a commit
that referenced
this pull request
Apr 30, 2026
Following ITK pull request #5692 "Deprecate `MultiThreaderType` aliases, use `MultiThreaderBase` directly"
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…ultiThreaderBase-instead-of-MultiThreaderType Deprecate `MultiThreaderType` aliases, use `MultiThreaderBase` directly
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
Following ITK pull request InsightSoftwareConsortium#5692 "Deprecate `MultiThreaderType` aliases, use `MultiThreaderBase` directly"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessObject::MultiThreaderTypeandImageToImageMetric::MultiThreaderTypeare always just aliases ofitk::MultiThreaderBase, the common base class of PlatformMultiThreader, PoolMultiThreader, and TBBMultiThreader. So it appears clearer to just useMultiThreaderBasedirectly.Deprecated those aliases,
ProcessObject::MultiThreaderTypeandImageToImageMetric::MultiThreaderType.