COMP: VTKImageIO publicly depends on ImageIOBase#5850
Merged
blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom Mar 2, 2026
Merged
COMP: VTKImageIO publicly depends on ImageIOBase#5850blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
Bot
added
type:Compiler
dzenanz
approved these changes
Mar 2, 2026
Member
|
/azp.run ITK.macOS.Python |
blowekamp
merged commit 1e4e9b8
into
InsightSoftwareConsortium:main
17 of 18 checks passed
7 tasks
Member
|
Backported to |
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 15, 2026
DCMTK, GE, LSM, and PhilipsREC have public headers that #include itkImageIOBase.h or inherit from ImageIOBase, making ITKIOImageBase a genuine public dependency. Move it from PRIVATE_DEPENDS to DEPENDS so downstream consumers receive the transitive include paths and link targets. Follows the same pattern as the VTK fix in PR InsightSoftwareConsortium#5850.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classes derived from ImageIOBase publicly depend on the interface.
Bug fix pulled from #5842
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.