COMP: Remove extraneous linking for VtkGlue Python#5861
COMP: Remove extraneous linking for VtkGlue Python#5861blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
With the improvement to use target interfaces for castxml and wrapping these options are extracted from the ITKVtkGlueModule interface and don't need to be specified again in wrapping.
|
/azp run ITK.macOS |
dzenanz
left a comment
There was a problem hiding this comment.
Cleanup looks good. CI does not test VTKGlue 😢
There is VTKGLue enable on the dashboard, but that has had test failures for a very long time. Do you know what's going on with those? |
|
I have attempted multiple times to get VTKGlue building and working on my computer, unsuccessfully, so I essentially gave up. I left the options turned on. |
|
I think my local tests passing with VTK and python when the GUI was used is good enough. @dzenanz We are almost to the point the expected nightly dashboard where the VTK tests failing may be the sole issue there... |
9bfc81b
into
InsightSoftwareConsortium:main
|
I will take another look. |
|
Shared libraries were enabled in the VTK builds, but the binary directories were not in the path. I now switched to static libraries. Let's see the dashboard tomorrow. |
|
Local build shows improvement after this change. |
|
Dashboard looks cleaner. I will take another look at still failing QuickViewTest. |
|
The crash happens inside VTK 9.6.0, in |
There may be multiple ITK libraries linked to those VTK static libraries. This would create duplicate symbols in ITK stared libraries for VTK. There are potential conflicting symbol resolution that might be happening. I agree it's a bad idea to mix them. |
With the improvement to use target interfaces for castxml and wrapping these options are extracted from the ITKVtkGlueModule interface and don't need to be specified again in wrapping.
The streamlining for the code was enabled by changes in #5842.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.