COMP: Update retired windows-2019 CI runner to windows-2022#6053
Conversation
|
| Filename | Overview |
|---|---|
| .github/workflows/pixi.yml | Replaced retired macos-15-intel runner with macos-13 (last available Intel macOS runner); matrix now covers Intel and Apple Silicon macOS correctly. |
| Testing/ContinuousIntegration/AzurePipelinesBatch.yml | Removed the v142/windows-2019 matrix entry (runner retired 2025-03-24, VS 2019 EOL); only v143/windows-2022 remains, which is valid and current. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before["Before (broken)"]
A1[windows-2019 / v142] -->|runner retired| X1((❌ silent fail))
A2[macos-15-intel] -->|runner never provisioned| X2((❌ silent fail))
A3[windows-2022 / v143] --> OK1((✅ ok))
A4[ubuntu-22.04] --> OK2((✅ ok))
A5[macos-14] --> OK3((✅ ok))
end
subgraph After["After (this PR)"]
B1[windows-2022 / v143] --> OK4((✅ ok))
B2[ubuntu-22.04] --> OK5((✅ ok))
B3[macos-13 Intel] --> OK6((✅ ok))
B4[macos-14 Apple Silicon] --> OK7((✅ ok))
end
Reviews (1): Last reviewed commit: "COMP: Remove retired CI runner images (w..." | Re-trigger Greptile
366f6ec to
50c98c5
Compare
dzenanz
left a comment
There was a problem hiding this comment.
We still officially support VS2019.
50c98c5 to
6312c2f
Compare
Migrate the v142 (VS2019 toolset) batch job from the retired windows-2019 runner to windows-2022. The v142 toolset is supported by Visual Studio 17 2022, so the generator is updated to match. This preserves v142 compiler compatibility testing while running on a supported runner image (windows-2019 retired 2025-03-24). Co-Authored-By: Dženan Zukić <dzenan.zukic@kitware.com>
6312c2f to
e870891
Compare
thewtex
left a comment
There was a problem hiding this comment.
@hjmjohnson thank you for updating the image!
|
only a stuck mac build is holding this up. |
f8b7abf
into
InsightSoftwareConsortium:release-5.4
Migrate the v142 (VS2019 toolset) batch job from the retired windows-2019 runner to windows-2022. Preserves v142 compiler compatibility testing on a supported runner image.
Changes
imageNamefromwindows-2019towindows-2022CTEST_CMAKE_GENERATORfrom"Visual Studio 16 2019"to"Visual Studio 17 2022"(v142 toolset works within VS2022)windows-2019was retired 2025-03-24