Skip to content

COMP: Update retired windows-2019 CI runner to windows-2022#6053

Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:release-5.4from
hjmjohnson:backport-fix-ci-runners
Apr 14, 2026
Merged

COMP: Update retired windows-2019 CI runner to windows-2022#6053
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:release-5.4from
hjmjohnson:backport-fix-ci-runners

Conversation

@hjmjohnson
Copy link
Copy Markdown
Member

@hjmjohnson hjmjohnson commented Apr 13, 2026

Migrate the v142 (VS2019 toolset) batch job from the retired windows-2019 runner to windows-2022. Preserves v142 compiler compatibility testing on a supported runner image.

Changes
  • Updated imageName from windows-2019 to windows-2022
  • Updated CTEST_CMAKE_GENERATOR from "Visual Studio 16 2019" to "Visual Studio 17 2022" (v142 toolset works within VS2022)
  • windows-2019 was retired 2025-03-24

@github-actions github-actions Bot added type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Apr 13, 2026
@hjmjohnson hjmjohnson requested a review from thewtex April 13, 2026 22:09
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 13, 2026

Greptile Summary

Removes two retired CI runner references that were causing silent failures on release-5.4: the windows-2019 / VS 2019 (v142) Azure Pipelines batch job (runner retired 2025-03-24) and the non-existent macos-15-intel GitHub Actions runner (replaced with macos-13, the last Intel macOS runner). The remaining matrix — windows-2022, ubuntu-22.04, macos-13, macos-14 — is current and covers both Intel and Apple Silicon macOS paths.

Confidence Score: 5/5

Safe to merge — purely removes broken/retired runner references with correct replacements; no logic changes.

Both changes are targeted, correct fixes for known broken CI configurations. macos-13 is the appropriate Intel macOS replacement, and removing windows-2019/v142 is necessary since that image no longer exists. No functional code is touched and remaining runners are all current.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/pixi.yml Replaced retired macos-15-intel runner with macos-13 (last available Intel macOS runner); matrix now covers Intel and Apple Silicon macOS correctly.
Testing/ContinuousIntegration/AzurePipelinesBatch.yml Removed the v142/windows-2019 matrix entry (runner retired 2025-03-24, VS 2019 EOL); only v143/windows-2022 remains, which is valid and current.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before["Before (broken)"]
        A1[windows-2019 / v142] -->|runner retired| X1((❌ silent fail))
        A2[macos-15-intel] -->|runner never provisioned| X2((❌ silent fail))
        A3[windows-2022 / v143] --> OK1((✅ ok))
        A4[ubuntu-22.04] --> OK2((✅ ok))
        A5[macos-14] --> OK3((✅ ok))
    end

    subgraph After["After (this PR)"]
        B1[windows-2022 / v143] --> OK4((✅ ok))
        B2[ubuntu-22.04] --> OK5((✅ ok))
        B3[macos-13 Intel] --> OK6((✅ ok))
        B4[macos-14 Apple Silicon] --> OK7((✅ ok))
    end
Loading

Reviews (1): Last reviewed commit: "COMP: Remove retired CI runner images (w..." | Re-trigger Greptile

@hjmjohnson hjmjohnson force-pushed the backport-fix-ci-runners branch from 366f6ec to 50c98c5 Compare April 14, 2026 00:03
@hjmjohnson hjmjohnson changed the title COMP: Remove retired CI runner images (windows-2019, macos-15-intel) COMP: Remove retired windows-2019 CI runner image Apr 14, 2026
Copy link
Copy Markdown
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still officially support VS2019.

Comment thread Testing/ContinuousIntegration/AzurePipelinesBatch.yml
Comment thread Testing/ContinuousIntegration/AzurePipelinesBatch.yml
Comment thread Testing/ContinuousIntegration/AzurePipelinesBatch.yml
@hjmjohnson hjmjohnson force-pushed the backport-fix-ci-runners branch from 50c98c5 to 6312c2f Compare April 14, 2026 01:45
@hjmjohnson hjmjohnson changed the title COMP: Remove retired windows-2019 CI runner image COMP: Update retired windows-2019 CI runner to windows-2022 Apr 14, 2026
@hjmjohnson hjmjohnson requested a review from dzenanz April 14, 2026 01:47
Migrate the v142 (VS2019 toolset) batch job from the retired
windows-2019 runner to windows-2022. The v142 toolset is supported
by Visual Studio 17 2022, so the generator is updated to match.
This preserves v142 compiler compatibility testing while running on
a supported runner image (windows-2019 retired 2025-03-24).

Co-Authored-By: Dženan Zukić <dzenan.zukic@kitware.com>
@hjmjohnson hjmjohnson force-pushed the backport-fix-ci-runners branch from 6312c2f to e870891 Compare April 14, 2026 11:30
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjmjohnson thank you for updating the image!

@thewtex thewtex added this to the ITK 5.4.6 milestone Apr 14, 2026
@hjmjohnson
Copy link
Copy Markdown
Member Author

only a stuck mac build is holding this up.

@hjmjohnson hjmjohnson merged commit f8b7abf into InsightSoftwareConsortium:release-5.4 Apr 14, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants