Skip to content

BUG: Fix float-precision division in BresenhamLine::BuildLine #6057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjmjohnson merged 1 commit into from
Apr 14, 2026
Merged

BUG: Fix float-precision division in BresenhamLine::BuildLine #6057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Modules/Core/Common/include/itkBresenhamLine.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ BresenhamLine<VDimension>::BuildLine(LType Direction, IdentifierType length) ->
// compute actual line length because the shorter distance
// the larger deviation due to rounding to integers
const IdentifierType mainDirectionLen = length - 1;
const double euclideanLineLen = mainDirectionLen / itk::Math::Absolute(Direction[maxDistanceDimension]);
const double euclideanLineLen =
static_cast<double>(mainDirectionLen) / static_cast<double>(itk::Math::Absolute(Direction[maxDistanceDimension]));

// we are going to start at 0
constexpr IndexType StartIndex{ 0 };
Expand Down
Loading