COMP: Replace dynamic DESCRIPTION in PolarTransform itk-module.cmake#6245
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:mainfrom May 9, 2026
Conversation
Drop the file(READ README.md DOCUMENTATION) preamble and replace
DESCRIPTION "${DOCUMENTATION}" with a static one-liner.
itk_module() is a CMake macro, so ARGN re-tokenizes its arguments and
list-splits any embedded ';' characters. The PolarTransform README
contains 4 semicolons, producing 4 spurious "Unknown argument"
AUTHOR_WARNINGs from CMake/ITKModuleMacros.cmake:111 on every
configure.
Same canonical fix applied in PR InsightSoftwareConsortium#6220 to RLEImage, SplitComponents,
IOFDF, IOMeshMZ3, IOMeshSTL; PolarTransform was missed because it
landed in parallel. The v4 ingestion pipeline (PR InsightSoftwareConsortium#6204) prevents
this regression via sanitize-history.py:patch_dynamic_description.
github-actions
Bot
added
type:Compiler
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 9, 2026
Replace the set(DOCUMENTATION "...") + DESCRIPTION "${DOCUMENTATION}"
indirection with a static one-liner literal.
itk_module() is a CMake macro, so ${ARGN} re-tokenizes its arguments
and list-splits any embedded ";". A future edit adding a semicolon or
"[" to the DOCUMENTATION string would silently produce spurious
"Unknown argument" AUTHOR_WARNINGs from CMake/ITKModuleMacros.cmake:111
on every configure (see PRs InsightSoftwareConsortium#6220, InsightSoftwareConsortium#6245).
The v4 ingestion pipeline (PR InsightSoftwareConsortium#6204) enforces this via
sanitize-history.py:patch_dynamic_description.
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 9, 2026
Replace the set(DOCUMENTATION "...") + DESCRIPTION "${DOCUMENTATION}"
indirection with a static one-liner literal.
itk_module() is a CMake macro, so ${ARGN} re-tokenizes its arguments
and list-splits any embedded ";". A future edit adding a semicolon or
"[" to the DOCUMENTATION string would silently produce spurious
"Unknown argument" AUTHOR_WARNINGs from CMake/ITKModuleMacros.cmake:111
on every configure (see PRs InsightSoftwareConsortium#6220, InsightSoftwareConsortium#6245).
The v4 ingestion pipeline (PR InsightSoftwareConsortium#6204) enforces this via
sanitize-history.py:patch_dynamic_description.
dzenanz
approved these changes
May 9, 2026
This comment was marked as resolved.
This comment was marked as resolved.
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 9, 2026
Replace the set(DOCUMENTATION "...") + DESCRIPTION "${DOCUMENTATION}"
indirection with a static one-liner literal.
itk_module() is a CMake macro, so ${ARGN} re-tokenizes its arguments
and list-splits any embedded ";". A future edit adding a semicolon or
"[" to the DOCUMENTATION string would silently produce spurious
"Unknown argument" AUTHOR_WARNINGs from CMake/ITKModuleMacros.cmake:111
on every configure (see PRs InsightSoftwareConsortium#6220, InsightSoftwareConsortium#6245).
The v4 ingestion pipeline (PR InsightSoftwareConsortium#6204) enforces this via
sanitize-history.py:patch_dynamic_description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
file(READ README.md DOCUMENTATION)preamble inModules/Filtering/PolarTransform/itk-module.cmakeand use a static one-lineDESCRIPTION. Silences 4Unknown argumentAUTHOR_WARNINGs on every configure.Root cause
itk_module()is a CMake macro, so${ARGN}re-tokenizes its arguments and list-splits any embedded;. The PolarTransformREADME.mdcontains 4 semicolons, producing 4 spuriousCMake Warning (dev): Unknown argument [...]messages fromCMake/ITKModuleMacros.cmake:111.Prior art
RLEImage,SplitComponents,IOFDF,IOMeshMZ3,IOMeshSTL. PolarTransform was ingested in parallel and slipped through.Utilities/Maintenance/RemoteModuleIngest/sanitize-history.py:patch_dynamic_descriptionso future ingests cannot reintroduce this regression.Verification
Modules/Filtering/PolarTransform/itk-module.cmake:14via the CDash configure log.pre-commit run --all-filespasses on the post-amend tree.