ENH: Support of VectorImage as template parameters for WarpImageFilter#8
Closed
jmichel-otb wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Closed
Conversation
This patch relates to issue InsightSoftwareConsortium#2895 ( https://issues.itk.org/jira/browse/ITK-2895#comment-27056 ) It is a straigthforward port of OTB patch provided by Julien Malik on his github page (see first comment) Patch summary: - In itkWarpImageFilter.h: - Replace HasNumericTraits concept checking on TInputImage::PixelType by checking on TInputImage::InternalPixelType, since HasNumericTraits will fail with VariableLengthVector as PixelType - In itkWarpImageFilter.txx: - Changed instanciation of m_EdgePaddingValue member to avoid calling NumericTraits< PixelType >::Zero, which does not exist for VariableLengthVector - Add further initialization of m_EdgePaddingValue in BeforeThreadedGenerateData, so that it will generate a VariableLenghtVector of appropriate length if needed - Avoid calling DisplacementType::Dimension and use the GetLength method from NumericTraits instead, which will support both static and dynamic (VariableLengthVector) length - In itkWarpImageFilterTest.cxx: - Added a simple test for template instanciation of WarpImageFilter using VectorImage for all three template parameters Change-Id: I44fb183dd6a684a23312446b2bc2d62e7f8eff7b
Contributor
Author
|
Note that I initially planned to push this patch to gerrit, but I am behind a firewall and did not manage to get http push working, though I carefully followed http://www.itk.org/Wiki/ITK/Git/Account#Gerrit : I am quite sure this worked for me in the past (I have 3 merged patches and 1 abandonned logged in gerrit already). |
Member
|
Uploaded to Gerrit here: |
HastingsGreer
pushed a commit
to HastingsGreer/ITK
that referenced
this pull request
Feb 11, 2019
ENH: Refactored SpatialObjectPoints and its derivatives
2 tasks
6 tasks
hjmjohnson
pushed a commit
that referenced
this pull request
Apr 25, 2026
DOC: Update FFT class names
hjmjohnson
added a commit
that referenced
this pull request
Apr 28, 2026
Fix test failure related to issue #7 Verified with problematic data set. Converted MGZ to nifti and back again. read all files into slicer and confirmed that reading and writing appears to work in all combinations.
hjmjohnson
pushed a commit
that referenced
this pull request
Apr 30, 2026
…licSection COMP: Move ITK_DISALLOW_COPY_AND_ASSIGN calls to public section.
hjmjohnson
pushed a commit
that referenced
this pull request
May 5, 2026
COMP: Address SetInput override virtual warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch relates to issue #2895 ( https://issues.itk.org/jira/browse/ITK-2895#comment-27056 )
It is a straigthforward port of OTB patch provided by Julien Malik on his github page (see first comment)
Patch summary:
Change-Id: I44fb183dd6a684a23312446b2bc2d62e7f8eff7b