Warp image filter vector image support#9
Closed
jmichel-otb wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
Closed
Warp image filter vector image support#9jmichel-otb wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
jmichel-otb wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
Conversation
This patch relates to issue InsightSoftwareConsortium#2895 ( https://issues.itk.org/jira/browse/ITK-2895#comment-27056 ) It is a straigthforward port of OTB patch provided by Julien Malik on his github page (see first comment) Patch summary: - In itkWarpImageFilter.h: - Replace HasNumericTraits concept checking on TInputImage::PixelType by checking on TInputImage::InternalPixelType, since HasNumericTraits will fail with VariableLengthVector as PixelType - In itkWarpImageFilter.txx: - Changed instanciation of m_EdgePaddingValue member to avoid calling NumericTraits< PixelType >::Zero, which does not exist for VariableLengthVector - Add further initialization of m_EdgePaddingValue in BeforeThreadedGenerateData, so that it will generate a VariableLenghtVector of appropriate length if needed - Avoid calling DisplacementType::Dimension and use the GetLength method from NumericTraits instead, which will support both static and dynamic (VariableLengthVector) length - In itkWarpImageFilterTest.cxx: - Added a simple test for template instanciation of WarpImageFilter using VectorImage for all three template parameters Change-Id: I44fb183dd6a684a23312446b2bc2d62e7f8eff7b
…e behaviour as in itk::ResampleImageFilter
Member
|
Thanks. The new patch has been uploaded. The old login system, Open-id based, no longer functions since most Open-id providers have dropped Open-id support. We added an account migration system that would associate your old account with the new OAuth login if the emails associated with each login (Open-id and GitHub) matched. Is your email julien.michel@orfeo-toolbox.org in your GitHub account profile? |
kwrobot
pushed a commit
to Kitware/ITK
that referenced
this pull request
Dec 14, 2016
Francois Budin (3):
BUG: Wrap RGB, RGBA, and Vector images types
ENH: Adding test for ITK images with RGB/RGBA/Vector pixels
ENH: Adding conversion from VNL objects to Numpy objects
Matt McCormick (3):
Merge pull request InsightSoftwareConsortium#9 from fbudin69500/WrapRGBRGBAVectorImages
Merge pull request InsightSoftwareConsortium#10 from fbudin69500/Add_tests_for_RGB_RGBA_Vector_images
Merge pull request InsightSoftwareConsortium#11 from fbudin69500/numpy_vnl_objects
Diff:
InsightSoftwareConsortium/ITKBridgeNumPy@9b5b17a...ab8df8c
Change-Id: Iffd201bb5b438cac64199bc969ba9b4ae44816e2
kwrobot
pushed a commit
to Kitware/ITK
that referenced
this pull request
Dec 16, 2016
…tion
Alexander Schmidt-Richberg (1):
BUG: Small bugs fixed to avoid compiler warnings (unsigned int and unused variable).
Francois Budin (6):
ENH: Replacing test data with MD5
STYLE: Improve style to pass KWStyle test
DOC: Missing backslash in documentation
COMP: Remove compilation warnings from Visual Studio
COMP: Correct warning due to locally defined symbol
Merge pull request InsightSoftwareConsortium#9 from fbudin69500/locally_defined_symbol
aschmiri (5):
Merge pull request #3 from thewtex/doxygen-warnings
Merge pull request #4 from fbudin69500/DOC_missing_backslash_in_documentation
Merge pull request #5 from fbudin69500/ENH_replace_test_data_with_MD5
Merge pull request #6 from fbudin69500/ImproveStyle
Merge pull request InsightSoftwareConsortium#7 from fbudin69500/remove_VS_warning_cherry_picked
Change-Id: Ibb959bc84e01edb6c3b78e0984d9f029992ff5af
2 tasks
6 tasks
hjmjohnson
pushed a commit
that referenced
this pull request
Apr 28, 2026
BUG: Ensure factory is registered once.
hjmjohnson
pushed a commit
that referenced
this pull request
Apr 30, 2026
BUG: Fix test errors steming from the new multi-threading mechanism.
hjmjohnson
pushed a commit
that referenced
this pull request
Apr 30, 2026
ENH: Add CI configuration files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new pull request is a revised version of gerrit issue http://review.source.kitware.com/#/c/20310/ , following Bradley Lowekamp comment.
I am still unable to push to gerrit through http with my account. Also note that I had to create another account (you can see two Julien Michel registered as reviewers to this topic) : I had an old account (before gerrit relying only on github ?), but I can not manage to login with it anymore (gerrit wants to go with github).