BUG: Use ProcessObject GetInput to obtain base pointer#946
Merged
blowekamp merged 1 commit intoMay 23, 2019
Merged
Conversation
dzenanz
approved these changes
May 22, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Looks like bug, judging by the (copy-pasted) comment above.
In ImageSinc::GenerateNthInputRequestedRegion, use superclass' GetInput method to obtain a pointer to a DataObject then a dynamic_cast can be used to determine if the image region can be generated. This addresses runtime "Unable to convert input" warnings.
blowekamp
force-pushed
the
FixImageSinkGenerateRRCasting
branch
from
fc22a9e to
b8aeae7
Compare
dzenanz
approved these changes
May 22, 2019
thewtex
approved these changes
May 23, 2019
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…ageSinkGenerateRRCasting BUG: Use ProcessObject GetInput to obtain base pointer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ImageSinc::GenerateNthInputRequestedRegion, use superclass'
GetInput method to obtain a pointer to a DataObject then a
dynamic_cast can be used to determine if the image region can be
generated. This addresses runtime "Unable to convert input" warnings.
closes #938.