Skip to content

ENH: Stop abort on first failure.#95

Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson:FAILING_CASTIMAGEFILETER
Nov 7, 2018
Merged

ENH: Stop abort on first failure.#95
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson:FAILING_CASTIMAGEFILETER

Conversation

@hjmjohnson
Copy link
Copy Markdown
Member

No description provided.

The ITKCastImageFilter test aborts on first failure.
When debugging it is sometimes helpful to know
all classes of failure rather than just the first
failure.

Change-Id: I08d48432c34df5d5aab89c8460755b3e597fcc3b
@hjmjohnson hjmjohnson force-pushed the FAILING_CASTIMAGEFILETER branch from bcbf564 to a728d97 Compare November 5, 2018 22:55
@hjmjohnson hjmjohnson requested a review from thewtex November 5, 2018 22:55
@hjmjohnson hjmjohnson self-assigned this Nov 5, 2018
@hjmjohnson hjmjohnson added the type:Style Style changes: no logic impact (indentation, comments, naming) label Nov 5, 2018
@hjmjohnson
Copy link
Copy Markdown
Member Author

The misty.kitware mac was failing on this test, but I can not replicate those failures on any other machine.

@hjmjohnson hjmjohnson closed this Nov 6, 2018
@hjmjohnson hjmjohnson deleted the FAILING_CASTIMAGEFILETER branch November 6, 2018 14:49
@hjmjohnson hjmjohnson restored the FAILING_CASTIMAGEFILETER branch November 6, 2018 19:21
@hjmjohnson
Copy link
Copy Markdown
Member Author

Accidently deleted/closed branch when the script for moving from Gerrit went haywire.

@hjmjohnson hjmjohnson reopened this Nov 6, 2018
@hjmjohnson hjmjohnson changed the title WIP: Stop abort on first failure. ENH: Stop abort on first failure. Nov 6, 2018
@hjmjohnson hjmjohnson requested a review from dzenanz November 7, 2018 00:36
@hjmjohnson hjmjohnson merged commit 0af8ca1 into InsightSoftwareConsortium:master Nov 7, 2018
@hjmjohnson hjmjohnson deleted the FAILING_CASTIMAGEFILETER branch October 23, 2019 13:29
hjmjohnson added a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
Update Modules/Remote/Cuberille.remote.cmake GIT_TAG from a152f89e to
upstream/main tip 4ba447f256a93428e56507178f92124bb91e3f3c.

Delta (2 commits):
  4ba447f Merge pull request InsightSoftwareConsortium#95 from update-ci-best-practices
  4afaf86 COMP: Update minimum Python version to 3.10+

This is a preparatory step for ingesting ITKCuberille as an inline beta
module under Modules/Beta/Cuberille/. Freezing at upstream tip ensures
the subsequent ingest matches what the remote-fetch path would have
retrieved.
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
hjmjohnson added a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
Update Modules/Remote/Cuberille.remote.cmake GIT_TAG from a152f89e to
upstream/main tip 4ba447f256a93428e56507178f92124bb91e3f3c.

Delta (2 commits):
  4ba447f Merge pull request InsightSoftwareConsortium#95 from update-ci-best-practices
  4afaf86 COMP: Update minimum Python version to 3.10+

This is a preparatory step for ingesting ITKCuberille as an inline beta
module under Modules/Beta/Cuberille/. Freezing at upstream tip ensures
the subsequent ingest matches what the remote-fetch path would have
retrieved.
hjmjohnson pushed a commit that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants