ENH: Use the itkNameOfTestExecutableMacro to get the test name#63
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Jul 30, 2019
Conversation
Member
Author
|
The CI's failing is due to the fact that the ITK commit being tested against is The macro at issue was still not present at that time in the |
dzenanz
approved these changes
Apr 9, 2019
Member
|
Thanks @jhlegarreta ! We can bump the ITK versions the Azure Pipelines configuration after 5.0 RC 2 is released, then this will be green for merge. |
Use the `itkNameOfTestExecutableMacro` to get the test name and prevent the the test from crashing when `argv[0]` is null, as recommended in: InsightSoftwareConsortium/ITK#564
Member
|
Rebasing on |
thewtex
force-pushed
the
UseITKNameOfTestExecutableMacro
branch
from
bf53694 to
6d29392
Compare
thewtex
approved these changes
Jul 30, 2019
Member
|
Thanks @jhlegarreta ! |
Member
Author
|
👍 @thewtex ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
itkNameOfTestExecutableMacroto get the test name and preventthe the test from crashing when
argv[0]is null, as recommended in:InsightSoftwareConsortium/ITK#564