Skip to content
This repository was archived by the owner on Jun 25, 2024. It is now read-only.

ENH: Transition project configuration to pyproject.toml#15

Open
jhlegarreta wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:TransitionToPyprojectToml
Open

ENH: Transition project configuration to pyproject.toml#15
jhlegarreta wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:TransitionToPyprojectToml

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

Transition project configuration to pyproject.toml.

Used the setup-py-to-pyproject-toml.py script in the ITKModuleTemplate repository:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate

as a starting base, then made manual changes as necessary.

Transition project configuration to `pyproject.toml`.

Used the `setup-py-to-pyproject-toml.py` script in the
`ITKModuleTemplate` repository:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate

as a starting base, then made manual changes as necessary.
@dzenanz
Copy link
Copy Markdown
Member

dzenanz commented Jun 25, 2024

#!/bin/bash -eo pipefail
ctest -j 2 -VV -S dashboard.cmake

* Extra verbosity turned on
Reading Script: /ITKNeuralNetworks-build/dashboard.cmake
CMake Error at /ITKNeuralNetworks-build/itk_common.cmake:96 (cmake_minimum_required):
  CMake 3.16.3 or higher is required.  You are running version 3.11.1
Call Stack (most recent call first):
  /ITKNeuralNetworks-build/dashboard.cmake:14 (include)

Exited with code exit status 255

CircleCI received exit code 255

@dzenanz
Copy link
Copy Markdown
Member

dzenanz commented Jun 25, 2024

Perhaps we should archive this repository, instead of trying to maintain it?

@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Jun 25, 2024

As you deem it wise @dzenanz; unfortunately, I do not have the bandwidth now to have a look and fix the previously existing issues, required changes to keep them up-to-date with newer ITK versions, or infrastructure (CMake, GitHub actions, etc.) on the 60 remotes; I just committed to the transition to pyproject.toml using the wonderful script Matt had developed. Apologies for that.

@dzenanz
Copy link
Copy Markdown
Member

dzenanz commented Jun 25, 2024

@hjmjohnson @thewtex what do you think?

@blowekamp
Copy link
Copy Markdown
Member

Perhaps we should archive this repository, instead of trying to maintain it?

I don't believe there is any modern utility to using the module any longer.

@thewtex
Copy link
Copy Markdown
Member

thewtex commented Jun 25, 2024

+1 for archiving. @hjmjohnson has removed it completely for ITK 6. I will go ahead and mark it as such.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants