COMP: Use ITK default branch origin/main in ASV config and docs#113
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Apr 23, 2026
Conversation
ITK's default branch has been `main` for some time; the ASV harness still referenced `origin/master`, causing `asv run` to abort with "Unknown branch origin/master in configuration" whenever the caller's itk-repo symlink pointed at a modern ITK checkout. - asv.conf.json: `branches` now lists `origin/main`. - README-asv.md: PR-comparison example uses `git merge-base origin/main HEAD`. No functional change for the benchmark code itself; the fix is purely to the branch identifier ASV uses to label the time series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITK's default branch renamed to
mainsome time ago; the ASV harness still referencedorigin/master, causingasv runto abort withUnknown branch origin/master in configurationwhenever the caller'sitk-reposymlink points at a modern ITK checkout. Switches the two in-repo references (asv.conf.json+README-asv.md).Failure signal that motivated this
Observed on InsightSoftwareConsortium/ITK#612 (ENH: Add performance benchmark CI builds), which runs this harness against
origin/mainITK:The ITK-side workflow currently carries a sed-patch workaround at harness-stage time; once this PR merges and #612's pin is bumped, that workaround can be deleted.
Scope
asv.conf.json:7—branches: ["origin/master"]→["origin/main"]README-asv.md:72— PR-comparison example now usesgit merge-base origin/main HEADNo functional change to the benchmark code or harness logic; the fix is purely to the branch identifier ASV uses to label the time series it writes to
.asv/results/.Note on this repo's own default branch
InsightSoftwareConsortium/ITKPerformanceBenchmarkingitself still usesmasteras its default branch (pergit remote show origin); thebranchesconfig here labels commits in the ITK checkout thatitk-repopoints at, not this repo's own branches. Renaming this repo's default branch is out of scope.