Skip to content

Fix python module building#137

Merged
dzenanz merged 4 commits intomasterfrom
fix-python-module-building
Feb 26, 2020
Merged

Fix python module building#137
dzenanz merged 4 commits intomasterfrom
fix-python-module-building

Conversation

@hjmjohnson
Copy link
Copy Markdown
Member

@hjmjohnson hjmjohnson commented Feb 25, 2020

No description provided.

@hjmjohnson
BUG: Variable name mismatch for wrapping
7691b0a 
The file `ITK/Wrapping/Generators/Python/CMakeLists.txt`
calls `include_directories("${Python3_INCLUDE_DIRS}")`
without calling find_package(Python3), which means that
the value for Python3_INCLUDE_DIR is not propagated to
Python3_INCLUDE_DIRS.
@hjmjohnson
ENH: Add fine grained failure testing for wrapping
7305e31 
provide diagnostic messages for common failure points in script.
@hjmjohnson
Copy link
Copy Markdown
Member Author

hjmjohnson commented Feb 25, 2020

Verified that this fixes many of the common test failures on a local machine.

@hjmjohnson
Copy link
Copy Markdown
Member Author

hjmjohnson commented Feb 25, 2020 

+ rm dist/itk_polartransform-1.1.1-cp37-cp37m-linux_x86_64.whl
+ for whl in 'dist/*linux_$(uname -p).whl'
+ auditwheel repair dist/itk_polartransform-1.1.1-cp38-cp38-linux_x86_64.whl -w /work/dist/
INFO:auditwheel.main_repair:Repairing itk_polartransform-1.1.1-cp38-cp38-linux_x86_64.whl
INFO:auditwheel.wheeltools:Previous filename tags: linux_x86_64
INFO:auditwheel.wheeltools:New filename tags: manylinux1_x86_64
INFO:auditwheel.wheeltools:Previous WHEEL info tags: cp38-cp38-linux_x86_64
INFO:auditwheel.wheeltools:New WHEEL info tags: cp38-cp38-manylinux1_x86_64
INFO:auditwheel.main_repair:
Fixed-up wheel written to /work/dist/itk_polartransform-1.1.1-cp38-cp38-manylinux1_x86_64.whl
+ rm dist/itk_polartransform-1.1.1-cp38-cp38-linux_x86_64.whl

This was referenced Feb 25, 2020
Closed
Merged
@hjmjohnson
Copy link
Copy Markdown
Member Author

hjmjohnson commented Feb 26, 2020

@thewtex @dzenanz This is a bottleneck to testing remote modules python generation. None of the remote modules can pass CI testing until these scripts are made to work again.

jhlegarreta
jhlegarreta reviewed Feb 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, a remarkable effort on the remotes. Thanks Hans.

A few in-line comments.

Comment thread scripts/dockcross-manylinux-download-cache-and-build-module-wheels.sh.orig Outdated
Comment thread scripts/dockcross-manylinux-download-cache-and-build-module-wheels.sh.orig Outdated
Comment thread scripts/dockcross-manylinux-download-cache-and-build-module-wheels.sh.orig Outdated
@hjmjohnson hjmjohnson force-pushed the fix-python-module-building branch from 044238d to 940e651 Compare February 26, 2020 13:25
jhlegarreta
jhlegarreta approved these changes Feb 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dzenanz dzenanz merged commit 033d13d into master Feb 26, 2020
@dzenanz dzenanz deleted the fix-python-module-building branch February 26, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz approved these changes

@jhlegarreta jhlegarreta jhlegarreta approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hjmjohnson @dzenanz @jhlegarreta