COMP: Add shell: bash to Download ITK step for Windows#130
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:v5.4.6from Apr 15, 2026
Merged
Conversation
The Download ITK step uses $ITK_BUILD_ROOT (bash syntax) but has no explicit shell: directive. On Windows, GitHub Actions defaults to pwsh where $ITK_BUILD_ROOT is undefined (needs $env:ITK_BUILD_ROOT). The cd becomes a no-op, ITK gets cloned into the repo checkout directory instead of the build root, and cmake fails with "source directory does not exist". Adding shell: bash ensures the step uses Git Bash on Windows, where $ITK_BUILD_ROOT correctly reads the environment variable.
dzenanz
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows CI failure introduced by #128: the Download ITK step uses
$ITK_BUILD_ROOT(bash syntax) without specifyingshell: bash, so on Windows it runs inpwshwhere the variable is undefined and thecdis a no-op.Same bug exists on
main— will open a matching PR after this merges.Root cause
GitHub Actions defaults to
pwshon Windows. In PowerShell, environment variables are accessed via$env:VAR, not$VAR. The "Build ITK (Windows)" step correctly uses$env:ITK_BUILD_ROOT, but the "Download ITK" step (which runs on all platforms) uses bash-style$ITK_BUILD_ROOTwithout an explicitshell: bashdirective.Result: ITK gets cloned into the repo checkout dir instead of the junction-shortened build root. The subsequent cmake configure fails with
The source directory "D:/PerformanceB/ITK" does not exist.Affected modules
Every module using
@v5.4.6on Windows is affected. Confirmed failing: ITKPerformanceBenchmarking#98.