Fixed choosing orientation for some previous INVALID conditions with greedy algorithm.#12
Merged
blowekamp merged 3 commits intoInsightSoftwareConsortium:masterfrom Apr 23, 2021
Conversation
Member
Author
|
The same issue exits in itk::OrientImageFilter. |
dzenanz
reviewed
Apr 22, 2021
| @@ -170,27 +170,50 @@ DICOMOrientation::DirectionCosinesToOrientation(const DirectionType & dir) | |||
| // but it is DIFFERENT in the meaning of direction in terms of sign-ness. | |||
Member
There was a problem hiding this comment.
in commit message closes -> closest
| switch (max_c) | ||
| { | ||
| case 0: { | ||
| // When the dominate axis sign is positive, assign the coordinate for the direction we are increasing towards. |
Member
There was a problem hiding this comment.
Is dominate an adjective? If not, change it to dominant (same as in commit message).
Member
Can you update it in the same way? |
zivy
approved these changes
Apr 22, 2021
The new method resolved the cases where there are no dominant direction in one or more axis. This method chooses the high value in the matrix first, then removes the invalid remaining values to select from.
blowekamp
force-pushed
the
FixOrientationSelection
branch
from
78a0b8e to
432d457
Compare
dzenanz
approved these changes
Apr 23, 2021
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
In second commit's title closes -> closest.
Member
Author
|
Thanks for the reviews :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses SimpleITK/SimpleITK#1375