fix(android): resolve flavor path correctly in upload sourcemaps #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
a7medev
requested changes
Sep 10, 2024
Contributor
a7medev
left a comment
a7medev
left a comment
There was a problem hiding this comment.
Can we please add a changelog item? 🙏🏼
a7medev
changed the title
a7medev
force-pushed
the
fix(android)/upload_sourcemap-gradle-task-flavor-issue
branch
from
92feab6 to
4ad2d1d
Compare
a7medev
requested review from
AyaMahmoud148,
a7medev,
andrewdanieldev and
kholood-ea
a7medev
approved these changes
Sep 23, 2024
andrewdanieldev
approved these changes
Sep 23, 2024
a7medev
deleted the
fix(android)/upload_sourcemap-gradle-task-flavor-issue
branch
YoussefFouadd
pushed a commit
that referenced
this pull request
Oct 16, 2024
* fix source map * fix: gradle sourcemap * fix: added changelog item * chore: update changelog * refactor: move flavor path to variable * refactor: make flavors backward-compatible --------- Co-authored-by: Ahmed Mahmoud <a7med.mahmoud2004@gmail.com> Signed-off-by: YoussefFouadd <yfouad@instabug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
fix(android): reading sourcemap file
Type of change
Related issues
JIRA ID: INSD-11595
Checklists
Development
Code review