fix(ios): report fatal crashes with the updated api #1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7medev
changed the title
Collaborator
ahmedAlaaInstabug
approved these changes
Sep 30, 2024
andrewdanieldev
approved these changes
Sep 30, 2024
YoussefFouadd
pushed a commit
that referenced
this pull request
Oct 16, 2024
* fix(ios): report fatal crashes with new api * chore: update changelog Signed-off-by: YoussefFouadd <yfouad@instabug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The API for reporting JavaScript crashes on iOS has been changed from
Instabug.reportCrashWithStackTracetoCrashReporting.cp_reportFatalCrashWithStackTracein the native iOS SDK as part of v13.1.0 but the React Native SDK wasn't updated to use the new API. This led to fatal JavaScript crashes being reported by the iOS SDK as native crashes rather than JavaScript crashes breaking symbolication for these crashes.This PR updates the API to be the new one to fix this bug.
Type of change
Related issues
Jira ID: MOB-16163
Checklists
Development
Code review