User sync fixes for 7 25 0#63
Merged
robson-viana merged 16 commits into7.25.0-insticatorfrom May 2, 2023
Merged
Conversation
|
|
||
| uid = localStorage.getItem(USER_ID_KEY); | ||
| if (uid && isUserIdValid(uid)) { | ||
| const domain = window.location.hostname.match(/[^.]*\.[^.]{2,3}(?:\.[^.]{2,3})?$/mg); |
There was a problem hiding this comment.
can you add one more logic here to extract the top-level-domain from the hostname & use that as the cookie domain. This way we can share the cookie across publisher's subdomain?
Not sure if that regex match operation is already doing that or not.
Author
There was a problem hiding this comment.
Yes, the regex match is taking the top level domain
rohanInsticator
left a comment
rohanInsticator
left a comment
There was a problem hiding this comment.
Other than that subdomain comment, everything else looks good to me. I also see multiple PRs open with this same logic, not sure what is what but the code looks the same. So please feel free to merge it after that subdomain check
himaneeshinsticator
pushed a commit
that referenced
this pull request
Jul 19, 2023
* User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * Update insticatorBidAdapter.js * Adding domain in the cookie. * Fixing unit test. * Adding logic for localhost.
himaneeshinsticator
added a commit
that referenced
this pull request
Jul 19, 2023
* Pull Insticator custom changes * User sync fixes. (#58) * User sync fixes for 7 25 0 (#59) * User sync fixes. * Update insticatorBidAdapter.js * User sync fixes for 7 25 0 (#60) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * User sync fixes for 7 25 0 (#61) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes for 7 25 0 (#62) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * User sync fixes for 7 25 0 (#63) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * Update insticatorBidAdapter.js * Adding domain in the cookie. * Fixing unit test. * Adding logic for localhost. * Merging changes from master into 7.25.0 (#65) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * Update insticatorBidAdapter.js * Adding domain in the cookie. * Fixing unit test. * Adding logic for localhost. * Adding new attributes for DealID. * put 'it' in the right place * User sync fix. (#68) * set impression type using header bidding wrapper's API (#66) * set impression type using header bidding wrapper's API * linter --------- Co-authored-by: Juan Jose Olivera <juan@insticator.com> Co-authored-by: Robson Viana <81261035+robson-viana@users.noreply.github.com> Co-authored-by: Bi Yoo <bi@insticator.com> Co-authored-by: Bi Yoo <95636458+insticator-biY@users.noreply.github.com>
himaneeshinsticator
pushed a commit
that referenced
this pull request
Jul 20, 2023
* User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * Update insticatorBidAdapter.js * Adding domain in the cookie. * Fixing unit test. * Adding logic for localhost.
himaneeshinsticator
added a commit
that referenced
this pull request
Jul 20, 2023
* Pull Insticator custom changes * User sync fixes. (#58) * User sync fixes for 7 25 0 (#59) * User sync fixes. * Update insticatorBidAdapter.js * User sync fixes for 7 25 0 (#60) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * User sync fixes for 7 25 0 (#61) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes for 7 25 0 (#62) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * User sync fixes for 7 25 0 (#63) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * Update insticatorBidAdapter.js * Adding domain in the cookie. * Fixing unit test. * Adding logic for localhost. * Merging changes from master into 7.25.0 (#65) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * Update insticatorBidAdapter.js * Adding domain in the cookie. * Fixing unit test. * Adding logic for localhost. * Adding new attributes for DealID. * put 'it' in the right place * User sync fix. (#68) * set impression type using header bidding wrapper's API (#66) * set impression type using header bidding wrapper's API * linter --------- Co-authored-by: Juan Jose Olivera <juan@insticator.com> Co-authored-by: Robson Viana <81261035+robson-viana@users.noreply.github.com> Co-authored-by: Bi Yoo <bi@insticator.com> Co-authored-by: Bi Yoo <95636458+insticator-biY@users.noreply.github.com>
himaneeshinsticator
pushed a commit
that referenced
this pull request
Jul 21, 2023
* User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * Update insticatorBidAdapter.js * Adding domain in the cookie. * Fixing unit test. * Adding logic for localhost.
himaneeshinsticator
added a commit
that referenced
this pull request
Jul 21, 2023
* Pull Insticator custom changes * User sync fixes. (#58) * User sync fixes for 7 25 0 (#59) * User sync fixes. * Update insticatorBidAdapter.js * User sync fixes for 7 25 0 (#60) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * User sync fixes for 7 25 0 (#61) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes for 7 25 0 (#62) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * User sync fixes for 7 25 0 (#63) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * Update insticatorBidAdapter.js * Adding domain in the cookie. * Fixing unit test. * Adding logic for localhost. * Merging changes from master into 7.25.0 (#65) * User sync fixes. * Update insticatorBidAdapter.js * Update insticatorBidAdapter_spec.js * Revert "Update insticatorBidAdapter_spec.js" This reverts commit ae1397a. * Revert "User sync fixes for 7 25 0 (#59)" This reverts commit 2ea50ac. * Update insticatorBidAdapter_spec.js * Update insticatorBidAdapter_spec.js * User sync fixes. prioritize local store over cookie to store the user ID, so that the same value can be shared among tabs. * Update insticatorBidAdapter.js * Update insticatorBidAdapter.js * Adding domain in the cookie. * Fixing unit test. * Adding logic for localhost. * Adding new attributes for DealID. * put 'it' in the right place * User sync fix. (#68) * set impression type using header bidding wrapper's API (#66) * set impression type using header bidding wrapper's API * linter --------- Co-authored-by: Juan Jose Olivera <juan@insticator.com> Co-authored-by: Robson Viana <81261035+robson-viana@users.noreply.github.com> Co-authored-by: Bi Yoo <bi@insticator.com> Co-authored-by: Bi Yoo <95636458+insticator-biY@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.