Skip to content

set impression type using header bidding wrapper's API #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
insticator-biY merged 2 commits into from
May 25, 2023
Merged

set impression type using header bidding wrapper's API #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bcb1c0
set impression type using header bidding wrapper's API
insticator-biY May 24, 2023
dca38de
linter
insticator-biY May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion modules/insticatorBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,26 @@ function buildImpression(bidRequest) {
insticator: {
adUnitId: bidRequest.params.adUnitId,
adUnitName: bidRequest.params.adUnitName,
impressionType: bidRequest.params.impressionType
},
}

/**
* set impression type using header bidding wrapper's API
* this is Insticator header bidding wrapper specific
Copy link

@standardguy standardguy May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this logic should be in our ad code. Do we want our prebid bid adapter to have code that depends on our header code implementation? I think we'd be better off just setting ext.insticator.impressionType in our ad code.

Copy link

@standardguy standardguy May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with @insticator-biY about this. As this is really meant to be used as part of our internal instiBid build this seems less of an issue. Let's go forward with this and see how it all works.

*/
// eslint-disable-next-line no-undef
if (bidRequest.adUnitCode && Insticator.getAdUnitStates) {
try {
// eslint-disable-next-line no-undef
const adUnits = Insticator.getAdUnitStates();
const adUnit = adUnits[bidRequest.adUnitCode]
// eslint-disable-next-line no-undef
if (adUnit) ext.insticator.impressionType = adUnit.timesRefreshed > 0 ? adUnit.refreshType : 'il';
} catch (e) {
console.warn(e)
}
}

const sizes =
deepAccess(bidRequest, 'mediaTypes.banner.sizes') || bidRequest.sizes;

Expand Down