Add support for Privacy Regulations | Fix video param validation#79
Add support for Privacy Regulations | Fix video param validation#79shubhamc-ins wants to merge 8 commits intoprebid-masterfrom
Conversation
- dsa - us_privacy/ccpa - gpp - gppSid
shubhamc-ins
changed the title
shubhamc-ins
force-pushed
the
INSTISSP-729-prebid-adapter-updates
branch
2 times, most recently
from
83b6f7c to
a553292
Compare
…tive bidder configs
| 'search': v => typeof v === 'string', | ||
| 'mobile': v => isInteger(), | ||
| 'content': v => typeof v === 'object', | ||
| 'keywords': v => typeof v === 'string', |
There was a problem hiding this comment.
even though this is under site in prebid js, we can use this for both site & content in bid requests on the exchange right?
There was a problem hiding this comment.
Also we are not doing any validation on content object from here. We can do that in exchange. @rohanInsticator
rohanInsticator
left a comment
rohanInsticator
left a comment
There was a problem hiding this comment.
how about another test-case if only one or more of the privacy policies are present?
And also, something more for video changes?
- remove video param validation
I added few more test cases and updated the PR. Please check now. @rohanInsticator |
| let regs = { | ||
| ext: {}, | ||
| }; | ||
| if (bidderRequest.gdprConsent) { |
There was a problem hiding this comment.
Check how rubicon adapter works, they pass consent string regardless of gdpr consent object is true or not. We should do that too since the consentString can be there for some Non-EU countries too. Please update the same for user object too
There was a problem hiding this comment.
Actually, if you see the latest code of rubicon.
They do check for gdprConsent and have removed the user.ext.consent as regs.ext.gdprConsentString servers the same purpose.
@rohanInsticator
There was a problem hiding this comment.
User consent is there in rubicon, not sure what you were checking
utils.deepSetValue(data, 'user.ext.consent', bidderRequest.gdprConsent.consentString);
There was a problem hiding this comment.
@rohanInsticator you are checking our repository, it's master is not synced with Prebid's official master branch.
Check this https://github.com/prebid/Prebid.js/blob/master/modules/rubiconBidAdapter.js
There was a problem hiding this comment.
I was looking at PrebidJS repo only in my intellij. I cannot pull the latest on master over there somehow. Even if rubicon has removed it, they must be appending it on the Server Side as IAB said it's good to have that field inside User Object too.
shubhamc-ins
force-pushed
the
INSTISSP-729-prebid-adapter-updates
branch
3 times, most recently
from
3780613 to
df112dc
Compare
2 participants
Uh oh!
There was an error while loading. Please reload this page.