Remove from bid if not viewable#82
Open
insticator-biY wants to merge 2 commits into9.26.0-Insticatorfrom
Open
Conversation
|
Did sanity, lgtm. Tg0 is always firing the /openrtb call whereas tg1 is firing it only for the ones which have > 50% viewability. |
sanmeet-shinde
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not meant to be merged
to test,
https://companycheck.co.uk/search?term=insticator&insticator_test_group=1&pbjs_debug=true <- new prebid adapter
https://companycheck.co.uk/search?term=insticator&insticator_test_group=0&pbjs_debug=true
the group 0 will make ortb request no matter what
the group 1 will make ortb request to our bidder only if it's viewable by iab standard
(all 3 placements got the request since they are viewable)
(only one that's >50% viewable got the bid since the other two side rails are not showing more than 50%)